public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb_storage: do not reset SanDisk Corporation U3 Cruzer Micro USB thumb drive
Date: Thu, 1 Jan 2009 02:52:01 -0500	[thread overview]
Message-ID: <200901010252.02827.vapier@gentoo.org> (raw)
In-Reply-To: <20081231193838.5DDF085AD247@gemini.denx.de>

On Wednesday 31 December 2008 14:38:38 Wolfgang Denk wrote:
> In message <200812310242.57366.vapier@gentoo.org> you wrote:
> > > > +	    /* SanDisk Corporation U3 Cruzer Micro 1/4GB
> > > > +	     * Flash Drive 000016244373FFB4 */
> > > > +	    (dev->descriptor.idVendor =3D=3D 0x0781 &&
> > > > +	     dev->descriptor.idProduct =3D=3D 0x5406)
> > >
> > > Please fix multiline comment style.
> >
> > you'll have to be a little more specific as to what exactly you have
> > issues with.  comment looks fine to me.
>
> Maybe you should read the CodingStyle document, too?

no need to be jerkish about it.  the style you quote says "preferred".  it is 
not "required".  there are a ton of multiline comments added to the tree which 
do not strictly fit this format.  so rather than me trying to magically read 
your mind to figure out what you're taking issue with, it's simpler to ask.  
and for you to respond with something simple like "the trailing */ needs to be 
on its own line".  but of course i'm just guessing here.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090101/1289a89f/attachment.pgp 

  reply	other threads:[~2009-01-01  7:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-30  7:59 [U-Boot] [PATCH] usb_storage: do not reset SanDisk Corporation U3 Cruzer Micro USB thumb drive Mike Frysinger
2008-12-30 22:52 ` Wolfgang Denk
2008-12-31  2:48   ` Bryan Wu
2008-12-31  7:42   ` Mike Frysinger
2008-12-31 19:38     ` Wolfgang Denk
2009-01-01  7:52       ` Mike Frysinger [this message]
2009-01-01  7:52       ` [U-Boot] [PATCH v2] " Mike Frysinger
2009-01-01  9:01         ` Wolfgang Denk
2009-01-01  9:10           ` Mike Frysinger
2009-01-01 10:32             ` Remy Bohmer
2009-01-02  0:48               ` [U-Boot] [PATCH] " Mike Frysinger
2009-01-02 11:26                 ` Jean-Christophe PLAGNIOL-VILLARD
2009-01-02 11:50                   ` Mike Frysinger
2009-01-02 12:47                     ` michael
2009-01-02 13:12                       ` Remy Bohmer
2009-01-04 20:33                 ` Remy Bohmer
2009-01-01 13:53             ` [U-Boot] [PATCH v2] " Wolfgang Denk
2009-01-01 23:32               ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901010252.02827.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox