[U-Boot] [PATCH v3 0/5] usb : musb : Add MUSB contorller driver and enable Davinci MSC support

[U-Boot] [PATCH v3 0/5] usb : musb : Add MUSB contorller driver and enable Davinci MSC support

[Thomas Abraham]

This patch series adds Mentor Graphics USB OTG host controller 
driver support and MSC support for DM6446 (TI DaVinci) platform. 

- [PATCH v3 1/5] usb : musb : Adding host controller driver for Mentor USB controller.
- [PATCH v3 2/5] usb : musb : Adding USB VBUS enable functionality for DM6446 DVEVM.
- [PATCH v3 3/5] usb : musb : Adding DM6446 (TI DaVinci) platform specific USB support.
- [PATCH v3 4/5] usb : musb : Enabling DM6446 (TI DaVinci) USB module power.
- [PATCH v3 5/5] usb : musb : Enabling USB MSC support for DM6446 (TI DaVinci) platform.

Note: This patch series depends on the following patch submitted by
Michael Trimarchi.

- [U-Boot] [USB PATCH] USB change speed

Changes since v2:

- Addressed changes suggested by Dirk Behme
- Added register overlay structure to access mentor USB module registers

Changes since v1:

- Rebased to U-Boot USB next branch
- Removed high element from usb_device structure

[U-Boot] [PATCH v3 0/5] usb : musb : Add MUSB contorller driver and enable Davinci MSC support

[Jean-Christophe PLAGNIOL-VILLARD]

On 09:40 Sun 04 Jan     , Thomas Abraham wrote:
> This patch series adds Mentor Graphics USB OTG host controller 
> driver support and MSC support for DM6446 (TI DaVinci) platform. 
> 
> - [PATCH v3 1/5] usb : musb : Adding host controller driver for Mentor USB controller.
> - [PATCH v3 2/5] usb : musb : Adding USB VBUS enable functionality for DM6446 DVEVM.
> - [PATCH v3 3/5] usb : musb : Adding DM6446 (TI DaVinci) platform specific USB support.
> - [PATCH v3 4/5] usb : musb : Enabling DM6446 (TI DaVinci) USB module power.
> - [PATCH v3 5/5] usb : musb : Enabling USB MSC support for DM6446 (TI DaVinci) platform.
> 
> Note: This patch series depends on the following patch submitted by
> Michael Trimarchi.
> 
> - [U-Boot] [USB PATCH] USB change speed
> 
> Changes since v2:
> 
> - Addressed changes suggested by Dirk Behme
which one no comment have been send to the ML?

Best Regards,
J.

[U-Boot] [PATCH v3 0/5] usb : musb : Add MUSB contorller driver and enable Davinci MSC support

[Mike Frysinger]

On Saturday 03 January 2009 23:10:26 Thomas Abraham wrote:
> This patch series adds Mentor Graphics USB OTG host controller
> driver support and MSC support for DM6446 (TI DaVinci) platform.

do you have a git tree or you just using the u-boot usb next git tree ?

also, what about the feedback Bryan sent you ?  i glanced at the comments he 
made and the source is unchanged from what i can see.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090104/39a8fade/attachment.pgp 

[U-Boot] [PATCH v3 0/5] usb : musb : Add MUSB contorller driver and enable Davinci MSC support

[Remy Bohmer]

Hello Thomas,

2009/1/4 Thomas Abraham <t-abraham@ti.com>:
> This patch series adds Mentor Graphics USB OTG host controller
> driver support and MSC support for DM6446 (TI DaVinci) platform.
>
> - [PATCH v3 1/5] usb : musb : Adding host controller driver for Mentor USB controller.
> - [PATCH v3 2/5] usb : musb : Adding USB VBUS enable functionality for DM6446 DVEVM.
> - [PATCH v3 3/5] usb : musb : Adding DM6446 (TI DaVinci) platform specific USB support.
> - [PATCH v3 4/5] usb : musb : Enabling DM6446 (TI DaVinci) USB module power.
> - [PATCH v3 5/5] usb : musb : Enabling USB MSC support for DM6446 (TI DaVinci) platform.
>

Before I loose track of all the versionnumbers of all the different
series that are somehow dependant on each other, I moved this series
to the 'testing' branch of u-boot-usb.
I leave the door open for an update of this series when there are
major comments on it.

Kind Regards,

Remy

> Note: This patch series depends on the following patch submitted by
> Michael Trimarchi.
>
> - [U-Boot] [USB PATCH] USB change speed
>
> Changes since v2:
>
> - Addressed changes suggested by Dirk Behme
> - Added register overlay structure to access mentor USB module registers
>
> Changes since v1:
>
> - Rebased to U-Boot USB next branch
> - Removed high element from usb_device structure
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

[U-Boot] [PATCH v3 0/5] usb : musb : Add MUSB contorller driver and enable Davinci MSC support

[Abraham, Thomas]

Jean,

> -----Original Message-----
> From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com] 
> Sent: Sunday, January 04, 2009 12:51 PM
> Subject: Re: [U-Boot] [PATCH v3 0/5] usb : musb : Add MUSB 
> contorller driver and enable Davinci MSC support

<snip>

> > Changes since v2:
> > 
> > - Addressed changes suggested by Dirk Behme
> which one no comment have been send to the ML?

It somehow missed being posted to the mailing list.

> Best Regards,
> J.
> 

Thanks,
Thomas.

[U-Boot] [PATCH v3 0/5] usb : musb : Add MUSB contorller driver and enable Davinci MSC support

[Abraham, Thomas]

Mike,
 
> -----Original Message-----
> From: Mike Frysinger [mailto:vapier at gentoo.org] 
> Sent: Sunday, January 04, 2009 11:00 PM
> Subject: Re: [U-Boot] [PATCH v3 0/5] usb : musb : Add MUSB 
> contorller driver and enable Davinci MSC support

<snip>

> 
> do you have a git tree or you just using the u-boot usb next 
> git tree ?

The Davinci USB patches are against the U-Boot USB 'next'
branch.
 
> also, what about the feedback Bryan sent you ?  i glanced at 
> the comments he made and the source is unchanged from what i can see.
> -mike
> 

I am sorry for having missed the feedback from Bryan (did not read
the emails received during vacation). I will included his 
comments as well.

Thanks,
Thomas.

[U-Boot] [PATCH v3 0/5] usb : musb : Add MUSB contorller driver and enable Davinci MSC support

[Bryan Wu]

Hi Thomas,

I'm still debugging the MUSB driver on my Blackfin board.
I got a issue here:
https://blackfin.uclinux.org/gf/project/u-boot/tracker/?action=TrackerItemEdit&tracker_id=153&tracker_item_id=4794

1. when the board power on and run 'usb start', the usb function is ok
for usb storage usage.
2. then I tried 'usb stop'. and run 'usb start' again. usb device
cannot be found.

Is that OK on davinci or omap platform?

Thanks
-Bryan

On Sun, Jan 4, 2009 at 12:10 PM, Thomas Abraham <t-abraham@ti.com> wrote:
> This patch series adds Mentor Graphics USB OTG host controller
> driver support and MSC support for DM6446 (TI DaVinci) platform.
>
> - [PATCH v3 1/5] usb : musb : Adding host controller driver for Mentor USB controller.
> - [PATCH v3 2/5] usb : musb : Adding USB VBUS enable functionality for DM6446 DVEVM.
> - [PATCH v3 3/5] usb : musb : Adding DM6446 (TI DaVinci) platform specific USB support.
> - [PATCH v3 4/5] usb : musb : Enabling DM6446 (TI DaVinci) USB module power.
> - [PATCH v3 5/5] usb : musb : Enabling USB MSC support for DM6446 (TI DaVinci) platform.
>
> Note: This patch series depends on the following patch submitted by
> Michael Trimarchi.
>
> - [U-Boot] [USB PATCH] USB change speed
>
> Changes since v2:
>
> - Addressed changes suggested by Dirk Behme
> - Added register overlay structure to access mentor USB module registers
>
> Changes since v1:
>
> - Rebased to U-Boot USB next branch
> - Removed high element from usb_device structure
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

[U-Boot] [PATCH v3 0/5] usb : musb : Add MUSB contorller driver and enable Davinci MSC support

[Abraham, Thomas]

Hi Bryan,

Sorry for the delayed reply. The sequence 'usb start' -> 'usb stop' -> 'usb start' works fine on Davinci and OMAP platforms.

Thanks,
Thomas.
 

> -----Original Message-----
> From: cooloney.lkml at gmail.com 
> [mailto:cooloney.lkml at gmail.com] On Behalf Of Bryan Wu
> Sent: Thursday, January 15, 2009 2:16 PM
> To: Abraham, Thomas
> Cc: u-boot at lists.denx.de; Gupta, Ajay Kumar; Subbrathnam, 
> Swaminathan; B, Ravi
> Subject: Re: [U-Boot] [PATCH v3 0/5] usb : musb : Add MUSB 
> contorller driver and enable Davinci MSC support
> 
> Hi Thomas,
> 
> I'm still debugging the MUSB driver on my Blackfin board.
> I got a issue here:
> https://blackfin.uclinux.org/gf/project/u-boot/tracker/?action
> =TrackerItemEdit&tracker_id=153&tracker_item_id=4794
> 
> 1. when the board power on and run 'usb start', the usb 
> function is ok for usb storage usage.
> 2. then I tried 'usb stop'. and run 'usb start' again. usb 
> device cannot be found.
> 
> Is that OK on davinci or omap platform?
> 
> Thanks
> -Bryan
> 
> On Sun, Jan 4, 2009 at 12:10 PM, Thomas Abraham 
> <t-abraham@ti.com> wrote:
> > This patch series adds Mentor Graphics USB OTG host 
> controller driver 
> > support and MSC support for DM6446 (TI DaVinci) platform.
> >
> > - [PATCH v3 1/5] usb : musb : Adding host controller driver 
> for Mentor USB controller.
> > - [PATCH v3 2/5] usb : musb : Adding USB VBUS enable 
> functionality for DM6446 DVEVM.
> > - [PATCH v3 3/5] usb : musb : Adding DM6446 (TI DaVinci) 
> platform specific USB support.
> > - [PATCH v3 4/5] usb : musb : Enabling DM6446 (TI DaVinci) 
> USB module power.
> > - [PATCH v3 5/5] usb : musb : Enabling USB MSC support for 
> DM6446 (TI DaVinci) platform.
> >
> > Note: This patch series depends on the following patch submitted by 
> > Michael Trimarchi.
> >
> > - [U-Boot] [USB PATCH] USB change speed
> >
> > Changes since v2:
> >
> > - Addressed changes suggested by Dirk Behme
> > - Added register overlay structure to access mentor USB module 
> > registers
> >
> > Changes since v1:
> >
> > - Rebased to U-Boot USB next branch
> > - Removed high element from usb_device structure
> >
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
> >
> 
> 

[U-Boot] [PATCH v3 0/5] usb : musb : Add MUSB contorller driver and enable Davinci MSC support

[Bryan Wu]

On Sat, Jan 17, 2009 at 5:22 PM, Abraham, Thomas <t-abraham@ti.com> wrote:
>
> Hi Bryan,
>
> Sorry for the delayed reply. The sequence 'usb start' -> 'usb stop' -> 'usb start' works fine on Davinci and OMAP platforms.
>

Thanks for the reply. And 2 more questions:

- there is no timeout control in the wait_until_xxx_ready() functions,
so when there no device plugged in u-boot will hang in these endless
loops.
- there is no root hub control, so we cannot use 'usb info' to get
device 0 root hub config info

do you have any plan to add these?

Best Regards,
-Bryan

> Thanks,
> Thomas.
>
>
>> -----Original Message-----
>> From: cooloney.lkml at gmail.com
>> [mailto:cooloney.lkml at gmail.com] On Behalf Of Bryan Wu
>> Sent: Thursday, January 15, 2009 2:16 PM
>> To: Abraham, Thomas
>> Cc: u-boot at lists.denx.de; Gupta, Ajay Kumar; Subbrathnam,
>> Swaminathan; B, Ravi
>> Subject: Re: [U-Boot] [PATCH v3 0/5] usb : musb : Add MUSB
>> contorller driver and enable Davinci MSC support
>>
>> Hi Thomas,
>>
>> I'm still debugging the MUSB driver on my Blackfin board.
>> I got a issue here:
>> https://blackfin.uclinux.org/gf/project/u-boot/tracker/?action
>> =TrackerItemEdit&tracker_id=153&tracker_item_id=4794
>>
>> 1. when the board power on and run 'usb start', the usb
>> function is ok for usb storage usage.
>> 2. then I tried 'usb stop'. and run 'usb start' again. usb
>> device cannot be found.
>>
>> Is that OK on davinci or omap platform?
>>
>> Thanks
>> -Bryan
>>
>> On Sun, Jan 4, 2009 at 12:10 PM, Thomas Abraham
>> <t-abraham@ti.com> wrote:
>> > This patch series adds Mentor Graphics USB OTG host
>> controller driver
>> > support and MSC support for DM6446 (TI DaVinci) platform.
>> >
>> > - [PATCH v3 1/5] usb : musb : Adding host controller driver
>> for Mentor USB controller.
>> > - [PATCH v3 2/5] usb : musb : Adding USB VBUS enable
>> functionality for DM6446 DVEVM.
>> > - [PATCH v3 3/5] usb : musb : Adding DM6446 (TI DaVinci)
>> platform specific USB support.
>> > - [PATCH v3 4/5] usb : musb : Enabling DM6446 (TI DaVinci)
>> USB module power.
>> > - [PATCH v3 5/5] usb : musb : Enabling USB MSC support for
>> DM6446 (TI DaVinci) platform.
>> >
>> > Note: This patch series depends on the following patch submitted by
>> > Michael Trimarchi.
>> >
>> > - [U-Boot] [USB PATCH] USB change speed
>> >
>> > Changes since v2:
>> >
>> > - Addressed changes suggested by Dirk Behme
>> > - Added register overlay structure to access mentor USB module
>> > registers
>> >
>> > Changes since v1:
>> >
>> > - Rebased to U-Boot USB next branch
>> > - Removed high element from usb_device structure
>> >
>> > _______________________________________________
>> > U-Boot mailing list
>> > U-Boot at lists.denx.de
>> > http://lists.denx.de/mailman/listinfo/u-boot
>> >
>>
>>