From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Mon, 5 Jan 2009 14:08:25 +0100
Subject: [U-Boot] [PATCH V2] ppc4xx: Fix UART baudrate setup by FDT
In-Reply-To: <200901021215.13810.matthias.fuchs@esd-electronics.com>
References: <200812281835.40995.mfuchs@ma-fu.de>
	<200901021215.13810.matthias.fuchs@esd-electronics.com>
Message-ID: <200901051408.25346.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Matthias,

On Friday 02 January 2009, Matthias Fuchs wrote:
> On ppc4xx platforms __ft_board_setup updates clock-frequency
> properties of all ns16550 compatible UARTs. This is not a good
> idea when those UARTs are external discrete UARTs that are
> not clocked by some internal clocks. So any external clock value
> in the DTB is overwritten and those UARTs will not be setup correctly
> by the Linux kernel.
>
> This patch uses the approach from fdt_fixup_ethernet(). Only UART nodes
> that have a serial* alias are updated.

Wouldn't it be "better" to check if an external UART clock is configured via 
CONFIG_SYS_EXT_SERIAL_CLOCK and just use it instead of the calculated 
internal clock value in this case?

BTW: This patch version is not ppc4xx specific as it touches the common 
fdt_support.c. So you would need to split this patch if we decide to go your 
way.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================