public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] ppc4xx: Fix UART baudrate setup by FDT
Date: Wed, 7 Jan 2009 16:37:28 +0100	[thread overview]
Message-ID: <200901071637.28700.sr@denx.de> (raw)
In-Reply-To: <200901062015.58355.matthias.fuchs@esd-electronics.com>

Hi Matthias,

On Tuesday 06 January 2009, Matthias Fuchs wrote:
> > >                   UART0: serial at ef600300 {
> > >                                 device_type = "serial";
> > >                                 compatible = "ns16550", "ibm,uart";
> > >                                 ...
> >
> > That could be done as well. Perhaps it's the "better" solution. You might
> > want to ask on the linuxppc-dev list if such a patch is welcome. If yes,
> > then we should go this way.
>
> Changing U-Boot to check for something different than ns16550 will break
> all board that have ns16550 in their dt.

Ah, your talking about compatibility problems with older dts files. 
Understood.

> The Linux kernel only checks for ns16550 compatible nodes under specific
> parents (see arch/powerpc/kernel/legacy_serial.c). For 4xx this is only
> "opb" and not even opb/ebc.
>
> So I think we should do it also this way. In this case we could keep the
> modification in U-Boots' cpu/ppc4xx/fdt.c.
>
> When you are with me I will try to prepare a patch.

Yes, this sounds like a good idea. Please go ahead.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

      reply	other threads:[~2009-01-07 15:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-28 17:35 [U-Boot] [PATCH] ppc4xx: Fix UART baudrate setup by FDT Matthias Fuchs
2009-01-02 11:15 ` [U-Boot] [PATCH V2] " Matthias Fuchs
2009-01-05 13:08   ` Stefan Roese
2009-01-05 20:10     ` Matthias Fuchs
2009-01-06  8:07       ` Stefan Roese
2009-01-06 19:15         ` Matthias Fuchs
2009-01-07 15:37           ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901071637.28700.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox