From: Ira Snyder <iws@ovro.caltech.edu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MPC8349EMDS: do not setup unused PCI clock outputsin PCI agent mode
Date: Mon, 12 Jan 2009 19:36:59 -0800 [thread overview]
Message-ID: <20090113033659.GB11065@ovro.caltech.edu> (raw)
In-Reply-To: <D7CCA83BB0796C49BC0BB53B6AB12089057140@zch01exm21.fsl.freescale.net>
On Tue, Jan 13, 2009 at 08:09:23AM +0800, Liu Dave wrote:
> > void pci_init_board(void)
> > {
> > volatile immap_t *immr = (volatile immap_t *)CONFIG_SYS_IMMR;
> > - volatile clk83xx_t *clk = (volatile clk83xx_t *)&immr->clk;
> > volatile law83xx_t *pci_law = immr->sysconf.pcilaw;
> > volatile pcictrl83xx_t *pci_ctrl = &immr->pci_ctrl[0];
> > struct pci_region *reg[] = { pci1_regions };
> >
> > - /* Enable all 8 PCI_CLK_OUTPUTS */
> > - clk->occr = 0xff000000;
> > - udelay(2000);
>
> It will cause the PCI host broken. It needs case by case
>
Yes, there are two pci_init_board() functions in this file. One for PCI
host mode, and one for PCI agent mode. This version only runs in agent
mode, it doesn't even get compiled in host mode.
It should be fine in host mode.
Thanks,
Ira
next prev parent reply other threads:[~2009-01-13 3:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 21:33 [U-Boot] [PATCH] MPC8349EMDS: do not setup unused PCI clock outputs in PCI agent mode Ira Snyder
2009-01-13 0:09 ` [U-Boot] [PATCH] MPC8349EMDS: do not setup unused PCI clock outputsin " Liu Dave
2009-01-13 3:36 ` Ira Snyder [this message]
2009-01-13 3:50 ` [U-Boot] [PATCH] MPC8349EMDS: do not setup unused PCI clockoutputsin " Liu Dave
2009-01-22 0:56 ` [U-Boot] [PATCH] MPC8349EMDS: do not setup unused PCI clock outputs in " Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113033659.GB11065@ovro.caltech.edu \
--to=iws@ovro.caltech.edu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox