public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] CFI: Add geometry reversal for STMicro M29W320ET
Date: Wed, 14 Jan 2009 12:55:52 +0100	[thread overview]
Message-ID: <200901141255.52717.sr@denx.de> (raw)
In-Reply-To: <200901131715.42506.vapier@gentoo.org>

On Tuesday 13 January 2009, Mike Frysinger wrote:
> On Tuesday 13 January 2009 12:31:46 Richard Retanubun wrote:
> > Added flash_fixup_stm to fix geometry reversal on
> > STMicro M29W320ET flash chip.
> >
> > Signed-off-by: Richard Retanubun <RichardRetanubun@RuggedCom.com>
> > ---
> >
> > Added flash_fixup_stm to fix geometry reversal on STMicro M29W320ET flash
> > chip.
> >
> > Modeled after flash_fixup_amd. this patch handles the geometry reversal
> > or erase sectors that exist for ST Micro (now Numonyx) M29W320ET flash.
> > Since I cannot test all STM's chips, the detection is implemented as
> > narrow as possible for now.
>
> this comment should be above the --- and in the changelog imo

ACK. Richard, please resend with this additional description in the main 
commit text.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2009-01-14 11:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-13 17:31 [U-Boot] [PATCH] CFI: Add geometry reversal for STMicro M29W320ET Richard Retanubun
2009-01-13 22:15 ` Mike Frysinger
2009-01-14 11:55   ` Stefan Roese [this message]
2009-01-14 13:44     ` [U-Boot] [PATCH V2] " Richard Retanubun
2009-01-26 10:00       ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901141255.52717.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox