public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nand read.jffs2 (nand_legacy) in common/cmd_nand.c
Date: Tue, 20 Jan 2009 19:32:39 +0100	[thread overview]
Message-ID: <200901201932.39877.sr@denx.de> (raw)
In-Reply-To: <20090120180930.GA10012@ld0162-tx32.am.freescale.net>

On Tuesday 20 January 2009, Scott Wood wrote:
> On Tue, Jan 20, 2009 at 04:57:55PM +0100, Schlaegl Manfred jun. wrote:
> > Error with CONFIG_NAND_LEGACY in common/cmd_nand.c:
> > With current code "nand read.jffs2s" (read and skip bad blocks) is always
> > interpreted as "nand read.jffs2" (read and fill bad blocks with 0xff).
> > This is because ".jffs2" is tested before ".jffs2s" and only the first
> > two characters are compared.
> >
> > Correction:
> > Test for ".jffs2s" first and compare the first 7 characters.
>
> I'll apply this, though I recommend switching to the non-legacy code
> (which always block-skips, BTW).  I'd like to see the legacy code go away
> soon.

Yes. How about setting a date for this removal? I suggest to remove it after 
the next two releases (after v2009-03/04).

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  parent reply	other threads:[~2009-01-20 18:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-20 15:57 [U-Boot] [PATCH] nand read.jffs2 (nand_legacy) in common/cmd_nand.c Schlaegl Manfred jun.
2009-01-20 18:09 ` Scott Wood
2009-01-20 18:14   ` Scott Wood
2009-01-20 18:32   ` Stefan Roese [this message]
2009-01-20 19:35     ` [U-Boot] Legacy NAND support to be removed after April 2009; please update your boards Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901201932.39877.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox