From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Tue, 20 Jan 2009 19:32:39 +0100
Subject: [U-Boot] [PATCH] nand read.jffs2 (nand_legacy) in
	common/cmd_nand.c
In-Reply-To: <20090120180930.GA10012@ld0162-tx32.am.freescale.net>
References: <1232467075.4313.24.camel@lisa.alm.archives.at>
	<20090120180930.GA10012@ld0162-tx32.am.freescale.net>
Message-ID: <200901201932.39877.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tuesday 20 January 2009, Scott Wood wrote:
> On Tue, Jan 20, 2009 at 04:57:55PM +0100, Schlaegl Manfred jun. wrote:
> > Error with CONFIG_NAND_LEGACY in common/cmd_nand.c:
> > With current code "nand read.jffs2s" (read and skip bad blocks) is always
> > interpreted as "nand read.jffs2" (read and fill bad blocks with 0xff).
> > This is because ".jffs2" is tested before ".jffs2s" and only the first
> > two characters are compared.
> >
> > Correction:
> > Test for ".jffs2s" first and compare the first 7 characters.
>
> I'll apply this, though I recommend switching to the non-legacy code
> (which always block-skips, BTW).  I'd like to see the legacy code go away
> soon.

Yes. How about setting a date for this removal? I suggest to remove it after 
the next two releases (after v2009-03/04).

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================