public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] USB: Change "usb tree" cmd to print 480MBit upon highspeed connection
Date: Thu, 22 Jan 2009 06:21:30 +0100	[thread overview]
Message-ID: <200901220621.30272.sr@denx.de> (raw)
In-Reply-To: <4977B761.805@gandalf.sssup.it>

On Thursday 22 January 2009, Michael Trimarchi wrote:
> Mike Frysinger wrote:
> > On Wednesday 21 January 2009 11:11:47 Stefan Roese wrote:
> >> Signed-off-by: Stefan Roese <sr@denx.de>
> >> ---
> >>  common/cmd_usb.c |    1 +
> >>  1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/common/cmd_usb.c b/common/cmd_usb.c
> >> index 9e55c7c..773d1b5 100644
> >> --- a/common/cmd_usb.c
> >> +++ b/common/cmd_usb.c
> >> @@ -310,6 +310,7 @@ void usb_show_tree_graph(struct usb_device *dev,
> >> char *pre) pre[index] = 0;
> >>  	printf(" %s (%s, %dmA)\n", usb_get_class_desc(
> >>  					dev->config.if_desc[0].bInterfaceClass),
> >> +					dev->speed == 2 ? "480MBit/s" :
> >>  					dev->speed ? "1.5MBit/s" : "12MBit/s",
> >>  					dev->config.MaxPower * 2);
> >>  	if (strlen(dev->mf) || strlen(dev->prod) || strlen(dev->serial))
>
> I personally prefer using the #define instead the number 1, 2, 3 (refer
> to linux/drivers/usb/core/hub.c)

OK, I'll provide a patch using the defines later today.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

      reply	other threads:[~2009-01-22  5:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-21 16:11 [U-Boot] [PATCH] USB: Change "usb tree" cmd to print 480MBit upon highspeed connection Stefan Roese
2009-01-21 16:18 ` Stefan Roese
2009-01-21 20:22 ` Mike Frysinger
2009-01-22  0:01   ` Michael Trimarchi
2009-01-22  5:21     ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901220621.30272.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox