public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] USB: Change "usb tree" cmd to print 480MBit upon highspeed connection
@ 2009-01-21 16:11 Stefan Roese
  2009-01-21 16:18 ` Stefan Roese
  2009-01-21 20:22 ` Mike Frysinger
  0 siblings, 2 replies; 5+ messages in thread
From: Stefan Roese @ 2009-01-21 16:11 UTC (permalink / raw)
  To: u-boot

Signed-off-by: Stefan Roese <sr@denx.de>
---
 common/cmd_usb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/common/cmd_usb.c b/common/cmd_usb.c
index 9e55c7c..773d1b5 100644
--- a/common/cmd_usb.c
+++ b/common/cmd_usb.c
@@ -310,6 +310,7 @@ void usb_show_tree_graph(struct usb_device *dev, char *pre)
 	pre[index] = 0;
 	printf(" %s (%s, %dmA)\n", usb_get_class_desc(
 					dev->config.if_desc[0].bInterfaceClass),
+					dev->speed == 2 ? "480MBit/s" :
 					dev->speed ? "1.5MBit/s" : "12MBit/s",
 					dev->config.MaxPower * 2);
 	if (strlen(dev->mf) || strlen(dev->prod) || strlen(dev->serial))
-- 
1.6.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] USB: Change "usb tree" cmd to print 480MBit upon highspeed connection
  2009-01-21 16:11 [U-Boot] [PATCH] USB: Change "usb tree" cmd to print 480MBit upon highspeed connection Stefan Roese
@ 2009-01-21 16:18 ` Stefan Roese
  2009-01-21 20:22 ` Mike Frysinger
  1 sibling, 0 replies; 5+ messages in thread
From: Stefan Roese @ 2009-01-21 16:18 UTC (permalink / raw)
  To: u-boot

Hi Remy,

I forgot to number those USB related patches. Here the list:

USB-Change-usb-tree-cmd-to-print-480MBit-upon-hig.patch
USB-Fix-speed-detection-on-EHCI-cntr-with-root-hub.patch
USB-Add-config-option-to-call-ehci_hcd_init-again.patch
USB-Add-dcache-support-to-the-EHCI-driver.patch
USB-Add-EHCI-support-for-VCT-EHCI-controller.patch

They are based on the usb/testing branch. Comments welcome.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] USB: Change "usb tree" cmd to print 480MBit upon highspeed connection
  2009-01-21 16:11 [U-Boot] [PATCH] USB: Change "usb tree" cmd to print 480MBit upon highspeed connection Stefan Roese
  2009-01-21 16:18 ` Stefan Roese
@ 2009-01-21 20:22 ` Mike Frysinger
  2009-01-22  0:01   ` Michael Trimarchi
  1 sibling, 1 reply; 5+ messages in thread
From: Mike Frysinger @ 2009-01-21 20:22 UTC (permalink / raw)
  To: u-boot

On Wednesday 21 January 2009 11:11:47 Stefan Roese wrote:
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  common/cmd_usb.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/common/cmd_usb.c b/common/cmd_usb.c
> index 9e55c7c..773d1b5 100644
> --- a/common/cmd_usb.c
> +++ b/common/cmd_usb.c
> @@ -310,6 +310,7 @@ void usb_show_tree_graph(struct usb_device *dev, char
> *pre) pre[index] = 0;
>  	printf(" %s (%s, %dmA)\n", usb_get_class_desc(
>  					dev->config.if_desc[0].bInterfaceClass),
> +					dev->speed == 2 ? "480MBit/s" :
>  					dev->speed ? "1.5MBit/s" : "12MBit/s",
>  					dev->config.MaxPower * 2);
>  	if (strlen(dev->mf) || strlen(dev->prod) || strlen(dev->serial))

we had a similar patch cooking locally for this

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090121/760a1c85/attachment.pgp 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] USB: Change "usb tree" cmd to print 480MBit upon highspeed connection
  2009-01-21 20:22 ` Mike Frysinger
@ 2009-01-22  0:01   ` Michael Trimarchi
  2009-01-22  5:21     ` Stefan Roese
  0 siblings, 1 reply; 5+ messages in thread
From: Michael Trimarchi @ 2009-01-22  0:01 UTC (permalink / raw)
  To: u-boot

Mike Frysinger wrote:
> On Wednesday 21 January 2009 11:11:47 Stefan Roese wrote:
>   
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> ---
>>  common/cmd_usb.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/common/cmd_usb.c b/common/cmd_usb.c
>> index 9e55c7c..773d1b5 100644
>> --- a/common/cmd_usb.c
>> +++ b/common/cmd_usb.c
>> @@ -310,6 +310,7 @@ void usb_show_tree_graph(struct usb_device *dev, char
>> *pre) pre[index] = 0;
>>  	printf(" %s (%s, %dmA)\n", usb_get_class_desc(
>>  					dev->config.if_desc[0].bInterfaceClass),
>> +					dev->speed == 2 ? "480MBit/s" :
>>  					dev->speed ? "1.5MBit/s" : "12MBit/s",
>>  					dev->config.MaxPower * 2);
>>  	if (strlen(dev->mf) || strlen(dev->prod) || strlen(dev->serial))
>>     
I personally prefer using the #define instead the number 1, 2, 3 (refer 
to linux/drivers/usb/core/hub.c)

Michael

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] USB: Change "usb tree" cmd to print 480MBit upon highspeed connection
  2009-01-22  0:01   ` Michael Trimarchi
@ 2009-01-22  5:21     ` Stefan Roese
  0 siblings, 0 replies; 5+ messages in thread
From: Stefan Roese @ 2009-01-22  5:21 UTC (permalink / raw)
  To: u-boot

On Thursday 22 January 2009, Michael Trimarchi wrote:
> Mike Frysinger wrote:
> > On Wednesday 21 January 2009 11:11:47 Stefan Roese wrote:
> >> Signed-off-by: Stefan Roese <sr@denx.de>
> >> ---
> >>  common/cmd_usb.c |    1 +
> >>  1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/common/cmd_usb.c b/common/cmd_usb.c
> >> index 9e55c7c..773d1b5 100644
> >> --- a/common/cmd_usb.c
> >> +++ b/common/cmd_usb.c
> >> @@ -310,6 +310,7 @@ void usb_show_tree_graph(struct usb_device *dev,
> >> char *pre) pre[index] = 0;
> >>  	printf(" %s (%s, %dmA)\n", usb_get_class_desc(
> >>  					dev->config.if_desc[0].bInterfaceClass),
> >> +					dev->speed == 2 ? "480MBit/s" :
> >>  					dev->speed ? "1.5MBit/s" : "12MBit/s",
> >>  					dev->config.MaxPower * 2);
> >>  	if (strlen(dev->mf) || strlen(dev->prod) || strlen(dev->serial))
>
> I personally prefer using the #define instead the number 1, 2, 3 (refer
> to linux/drivers/usb/core/hub.c)

OK, I'll provide a patch using the defines later today.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-01-22  5:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-21 16:11 [U-Boot] [PATCH] USB: Change "usb tree" cmd to print 480MBit upon highspeed connection Stefan Roese
2009-01-21 16:18 ` Stefan Roese
2009-01-21 20:22 ` Mike Frysinger
2009-01-22  0:01   ` Michael Trimarchi
2009-01-22  5:21     ` Stefan Roese

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox