From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Thu, 22 Jan 2009 09:29:08 +0100 Subject: [U-Boot] [PATCH 1/1] arm: fix some arch_number definition In-Reply-To: <20090122074030.57565832E425@gemini.denx.de> References: <1232603494-14583-1-git-send-email-plagnioj@jcrosoft.com> <1232603494-14583-2-git-send-email-plagnioj@jcrosoft.com> <20090122074030.57565832E425@gemini.denx.de> Message-ID: <20090122082908.GC15551@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08:40 Thu 22 Jan , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <1232603494-14583-2-git-send-email-plagnioj@jcrosoft.com> you wrote: > > > > diff --git a/board/armadillo/armadillo.c b/board/armadillo/armadillo.c > > index ca5bd1d..e9be758 100644 > > --- a/board/armadillo/armadillo.c > > +++ b/board/armadillo/armadillo.c > > @@ -42,8 +42,7 @@ int board_init (void) > > /* Activate LED flasher */ > > IO_LEDFLSH = 0x40; > > > > - /* arch number MACH_TYPE_ARMADILLO - not official*/ > > - gd->bd->bi_arch_number = 83; > > + gd->bd->bi_arch_number = MACH_TYPE_ARMADILLO; > > > > /* location of boot parameters */ > > gd->bd->bi_boot_params = 0xc0000100; > > You actually CHANGE the arch_number here; you need the board > maintainer's ACK for such a patch. the ARMADILLO was changed in the current kernel it's not any more 83 but 615 83 is used for board that does not have any valid MACHINE ID > > Note that there are other places where this is used - these must be > changed, too - for example: > > "board/lpc2292sodimm/lpc2292sodimm.c": > > 42 /* arch number MACH_TYPE_ARMADILLO - not official*/ > 43 gd->bd->bi_arch_number = 83; I've not find it in the official list so I've let as 83 (non registered board) > > "board/siemens/SMN42/smn42.c": > > 42 /* arch number MACH_TYPE_ARMADILLO - not official*/ > 43 gd->bd->bi_arch_number = 83; ditto > > I recommend you got through this again, more thoroughly. > > > index 3ad756d..205bd3a 100644 > > --- a/board/cmc_pu2/cmc_pu2.c > > +++ b/board/cmc_pu2/cmc_pu2.c > > @@ -96,12 +96,7 @@ int board_init (void) > > piob->PIO_PER = AT91C_PIO_PB3 | AT91C_PIO_PB4 | > > AT91C_PIO_PB5 | AT91C_PIO_PB6; > > > > - /* > > - * arch number of CMC_PU2-Board. MACH_TYPE_CMC_PU2 is not supported in > > - * the linuxarm kernel, yet. > > - */ > > - /* gd->bd->bi_arch_number = MACH_TYPE_CMC_PU2; */ > > - gd->bd->bi_arch_number = 251; > > + gd->bd->bi_arch_number = MACH_TYPE_CMC_PU2; > > /* adress of boot parameters */ > > gd->bd->bi_boot_params = PHYS_SDRAM + 0x100; > > You actually CHANGE the arch_number here; you need the board > maintainer's ACK for such a patch. as precedently it's the current MACHINE ID 251 is used for AT91RM9200 > > > diff --git a/board/imx31_phycore/imx31_phycore.c b/board/imx31_phycore/imx31_phycore.c > > index ae93444..4b72d57 100644 > > --- a/board/imx31_phycore/imx31_phycore.c > > +++ b/board/imx31_phycore/imx31_phycore.c > > @@ -60,7 +60,7 @@ int board_init (void) > > mx31_gpio_mux(MUX_CSPI2_MOSI__I2C2_SCL); > > mx31_gpio_mux(MUX_CSPI2_MISO__I2C2_SDA); > > > > - gd->bd->bi_arch_number = 447; /* board id for linux */ > > + gd->bd->bi_arch_number = MACH_TYPE_MX31ADS; /* board id for linux */ > > gd->bd->bi_boot_params = (0x80000100); /* adress of boot parameters */ > > MX31ADS ? > > > diff --git a/board/ns9750dev/ns9750dev.c b/board/ns9750dev/ns9750dev.c > > index fc46244..b8f377b 100644 > > --- a/board/ns9750dev/ns9750dev.c > > +++ b/board/ns9750dev/ns9750dev.c > > @@ -68,7 +68,7 @@ int board_init( void ) > > #warning Please register your machine at http://www.arm.linux.org.uk/developer/machines/?action=new > > /* arch number of OMAP 1510-Board */ > > /* to be changed for OMAP 1610 Board */ > > - gd->bd->bi_arch_number = 234; > > + gd->bd->bi_arch_number = MACH_TYPE_NS9750; > > You actually CHANGE the arch_number here; you need the board > maintainer's ACK for such a patch. 234 is use for OMAP_INNOVATOR not the ns9750 so I've correct it I any board maintainer have a problem with it I'm open Best Regards, J.