From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Tue, 27 Jan 2009 06:16:52 +0100
Subject: [U-Boot] [PATCH] jedec_flash: Fix compilation warning in
	jedec_flash.c
In-Reply-To: <20090126194402.B4D7B832E416@gemini.denx.de>
References: <1232960742-9121-1-git-send-email-sr@denx.de>
	<20090126194402.B4D7B832E416@gemini.denx.de>
Message-ID: <200901270616.52557.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

On Monday 26 January 2009, Wolfgang Denk wrote:
> > diff --git a/drivers/mtd/jedec_flash.c b/drivers/mtd/jedec_flash.c
> > index 2d99d4d..879f25e 100644
> > --- a/drivers/mtd/jedec_flash.c
> > +++ b/drivers/mtd/jedec_flash.c
> > @@ -172,7 +172,7 @@ struct amd_flash_info {
> >  static const struct amd_flash_info jedec_table[] = {
> >  #ifdef CONFIG_SYS_FLASH_LEGACY_256Kx8
> >  	{
> > -		.mfr_id		= MANUFACTURER_SST,
> > +		.mfr_id		= (u16)MANUFACTURER_SST,
>
> Which toolchain is throwing which exact warnings here? For which
> board?
>
> I don't think this should be needed. MANUFACTURER_SST is defined as
> 0x00BF - this hsould give no conflicts here.

Your correct this line doesn't give a waring. The toolchain is ELDK
4.2. But the warning is "only" in line 219:

[stefan at kubuntu u-boot (master)]$ ./MAKEALL hcu4
Configuring for hcu4 board...
jedec_flash.c:219: warning: large integer implicitly truncated to unsigned type

Some of the manufacturer defines are defined (again) 16bit wide
in jedec_flash.c, and one (STM_MANUFACT) is defined 32bit wide
in include/flash.h (0x00200020). 

Perhaps its better to remove those double manufacturer defines from
jedec_flash.c? Just let me know if you would prefer such a version
and I will generate a patch for it.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================