public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] arm: fix some arch_number definition
Date: Tue, 27 Jan 2009 14:05:33 +0100	[thread overview]
Message-ID: <20090127130533.GA26615@game.jcrosoft.org> (raw)
In-Reply-To: <m2hc3lj6s0.fsf@ohwell.denx.de>

On 13:02 Tue 27 Jan     , Detlev Zundel wrote:
> Hi Jean-Christophe,
> 
> >> > > Note that there are other places where this is used - these must be
> >> > > changed, too - for example:
> >> > > 
> >> > > "board/lpc2292sodimm/lpc2292sodimm.c":
> >> > > 
> >> > >  42         /* arch number MACH_TYPE_ARMADILLO - not official*/
> >> > >  43         gd->bd->bi_arch_number = 83;
> >> > I've not find it in the official list so I've let as 83 (non registered board)
> >> 
> >> You canged the old "MACH_TYPE_ARMADILLO" / 83 setting in one place but
> >> not in others? This will cause inconsistent behaviour.
> >> 
> >> You must not do that.  Either leave ALL of these as they are, or fix
> >> ALL of them in the SAME way.
> > the other board are not a ARMODILLO correct if I wrong
> 
> Why not correct the wrong comment?  I think this is the consistent thing
> to do, as there certainly is no definition for "83" in the kernel and 83
> has nothing to do with ARMADILLO.
This make sense
anyway normaly no new arm board will not have a valid machine id now

Best Regards,
J.

  parent reply	other threads:[~2009-01-27 13:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-22  5:51 [U-Boot] [PATCH 0/1] arm/mach-types: sync with 2.6.28 and add generating tools support Jean-Christophe PLAGNIOL-VILLARD
2009-01-22  5:51 ` [U-Boot] [PATCH 1/1] arm: fix some arch_number definition Jean-Christophe PLAGNIOL-VILLARD
2009-01-22  6:51   ` Jens Gehrlein
2009-01-22  8:34     ` Jean-Christophe PLAGNIOL-VILLARD
2009-02-03 11:25       ` Guennadi Liakhovetski
2009-01-22  7:40   ` Wolfgang Denk
2009-01-22  8:29     ` Jean-Christophe PLAGNIOL-VILLARD
2009-01-22 10:46       ` Wolfgang Denk
2009-01-22 11:13         ` Jean-Christophe PLAGNIOL-VILLARD
2009-01-22 16:33           ` Wolfgang Denk
2009-01-27 12:02           ` Detlev Zundel
2009-01-27 12:09             ` Wolfgang Denk
2009-01-27 13:05             ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-01-22 11:21   ` Jean-Christophe PLAGNIOL-VILLARD
2009-01-22  7:42 ` [U-Boot] [PATCH 0/1] arm/mach-types: sync with 2.6.28 and add generating tools support Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090127130533.GA26615@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox