From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] saveenv: standardize enablement
Date: Wed, 28 Jan 2009 09:17:06 +0100 [thread overview]
Message-ID: <20090128081706.0B650832E416@gemini.denx.de> (raw)
In-Reply-To: <20090127213539.1AB49832E416@gemini.denx.de>
Dear Mike,
In message <1230623965-16546-1-git-send-email-vapier@gentoo.org> you wrote:
> Rather than special casing each environment type for enabling the saveenv
> command, have them all behave the same. This avoids bitrot as new env
> sources are added/removed.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> common/cmd_nvedit.c | 26 ++++++++------------------
> 1 files changed, 8 insertions(+), 18 deletions(-)
This patch breaks support for the
This board is a bit unusual as it is ROM based - it has
CONFIG_ENV_IS_IN_FLASH set because the default environment is embedded in
the ROM, but does not enable the flash driver (because there is no
flash on the board). So the test in "common/cmd_nvedit.c":
549 #if defined(CONFIG_CMD_ENV) && !defined(CONFIG_ENV_IS_NOWHERE)
fails - it enables do_saveenv(), but there is no underlying saveenv()
function. Result:
common/libcommon.a(cmd_nvedit.o): In function `do_saveenv':
common/cmd_nvedit.c:557: undefined reference to `saveenv'
make: *** [u-boot] Error 1
Please fix.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Never underestimate the bandwidth of a station wagon full of tapes.
-- Dr. Warren Jackson, Director, UTCS
next prev parent reply other threads:[~2009-01-28 8:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-30 7:59 [U-Boot] [PATCH] saveenv: standardize enablement Mike Frysinger
2009-01-26 4:13 ` Mike Frysinger
2009-01-27 21:35 ` Wolfgang Denk
2009-01-28 8:17 ` Wolfgang Denk [this message]
2009-01-28 8:50 ` Mike Frysinger
2009-01-28 9:03 ` Wolfgang Denk
2009-01-28 18:48 ` [U-Boot] [PATCH] SPD823TS: do not define CONFIG_CMD_ENV Mike Frysinger
2009-01-28 18:54 ` Mike Frysinger
2009-01-28 21:24 ` Wolfgang Denk
2009-01-28 21:23 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090128081706.0B650832E416@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox