From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Wed, 28 Jan 2009 12:56:14 +0100
Subject: [U-Boot] [PATCH 02/31] environment,
	netconsole: reducing packages when printing environment variables
In-Reply-To: <20090128113108.79AF9832E416@gemini.denx.de>
References: <4980279F.2020302@denx.de> <49803324.3000709@denx.de>
	<20090128113108.79AF9832E416@gemini.denx.de>
Message-ID: <200901281256.14264.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday 28 January 2009, Wolfgang Denk wrote:
> > > Why not fold this "putc()" into the puts() above (replace it with
> > > printf)?
> >
> > I make it in a printf (Think there was no reason for not doing it so)
>
> Check if printf() is not printing a series of single characters again!
> Also, we tend to prefer using puts() / putc() over printf() because of
> the huge performance overhead involved in printf() when only plain
> constant strings need to be printed.

printf() is already used in the 2nd part of the patch. But the 1st string can 
also be concat-ed of course and printed via puts(). printf() would be easier 
to read though from my point of view.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================