From: Kim Phillips <kim.phillips@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 18/31] mpc83xx, kmeter1: add I2C, dtt, eeprom support
Date: Wed, 28 Jan 2009 20:10:02 -0600 [thread overview]
Message-ID: <20090128201002.18f12c92.kim.phillips@freescale.com> (raw)
In-Reply-To: <498027F4.3080103@denx.de>
On Wed, 28 Jan 2009 10:40:04 +0100
Heiko Schocher <hs@denx.de> wrote:
> +static int board_init_i2c_busses (void)
> +{
> + I2C_MUX_DEVICE *dev = NULL;
> + uchar *buf;
> +
> + /* Set up the Bus for the DTTs */
> + buf = (unsigned char *) getenv ("DTT_bus");
the environment is case sensitive; can we be more case-consistent
with names we expect from it?
> + if (buf != NULL)
> + dev = i2c_mux_ident_muxstring (buf);
> + if (dev == NULL) {
> + printf ("Error couldnt add Bus for DTT\n");
s/couldnt/couldn't/, add something like "please setenv dtt_bus
<insert something reasonable here>"
> + return 0;
are you sure you shouldn't be returning an error code? otherwise this
line is not necessary.
> + }
> + return 0;
> +}
> +
Kim
next prev parent reply other threads:[~2009-01-29 2:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 9:40 [U-Boot] [PATCH 18/31] mpc83xx, kmeter1: add I2C, dtt, eeprom support Heiko Schocher
2009-01-29 2:10 ` Kim Phillips [this message]
2009-01-29 9:05 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090128201002.18f12c92.kim.phillips@freescale.com \
--to=kim.phillips@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox