From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Thu, 29 Jan 2009 16:48:01 -0500 Subject: [U-Boot] [PATCH 01/27 v2] Blackfin: bfin_mac: force board_get_enetaddr() usage In-Reply-To: <20090129211709.3DBF9832E416@gemini.denx.de> References: <49814203.7020604@gmail.com> <200901291605.09474.vapier@gentoo.org> <20090129211709.3DBF9832E416@gemini.denx.de> Message-ID: <200901291648.02480.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 29 January 2009 16:17:09 Wolfgang Denk wrote: > In message <200901291605.09474.vapier@gentoo.org> you wrote: > > > Rather: > > > > > > - misc_init_r() [or similar] sets up ethaddr in env if it isnt > > > set already and sets bi_enetaddr in global data > > > - board_eth_init() calls the driver init > > > (bfin_EMAC_initialize() in your case) > > > - driver init looks up ethaddr in env or bi_enetaddr > > > > well this gets us into the realm of what i was trying to avoid/fix in the > > first place: duplication of the env/ethaddr handling/parsing code. i get > > What is wrong with using bi_enetaddr? What sort of "handling/parsing > code" (in addition to a plain simple memcpy(...,6) is needed? converting the envvar to the raw 6 bytes and back again is duplicated all over the tree. and you suggest that both the board-specific misc_initr() and the driver init should handle this. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20090129/e2e502b1/attachment.pgp