From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Date: Thu, 5 Feb 2009 20:52:07 +0100
Subject: [U-Boot] [PATCH 4/7] OMAP3: Pandora: Update pin mux
In-Reply-To: <498B3A54.9010907@googlemail.com>
References: <1233554011-30084-1-git-send-email-dirk.behme@googlemail.com>
	<1233554011-30084-2-git-send-email-dirk.behme@googlemail.com>
	<1233554011-30084-3-git-send-email-dirk.behme@googlemail.com>
	<1233554011-30084-4-git-send-email-dirk.behme@googlemail.com>
	<1233554011-30084-5-git-send-email-dirk.behme@googlemail.com>
	<20090204232412.GK31498@game.jcrosoft.org>
	<498B3A54.9010907@googlemail.com>
Message-ID: <20090205195207.GD4580@game.jcrosoft.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 20:13 Thu 05 Feb     , Dirk Behme wrote:
> Dear Jean-Christophe,
>
> Jean-Christophe PLAGNIOL-VILLARD wrote:
>> On 06:53 Mon 02 Feb     , Dirk Behme wrote:
>>> Update Pandora pin mux.
>> for what and why?
>
> Well, this is a very good example of why it is good to "use macros  
> instead of hard coded values" :)
>
> Looking at the changes done in this patch, thanks to the macros used, it 
> is obvious that here pulls are enabled for MMC data/cmd lines, and  
> disabled for clock line. In case you are familiar with MMC hardware  
> configuration, you should know why this is necessary.
so please update the commit message to explain it

Best Regards,
J.