public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] ppc4xx: Make PCIE support selectable
@ 2009-02-03 14:15 Dirk Eibach
  2009-02-06 10:12 ` Stefan Roese
  2009-02-07 21:39 ` Wolfgang Denk
  0 siblings, 2 replies; 3+ messages in thread
From: Dirk Eibach @ 2009-02-03 14:15 UTC (permalink / raw)
  To: u-boot

On some platforms PCIE support is not required, but would be included
because the cpu supports it. To reduce fooprint it is now configurable
via CONFIG_PCI_DISABLE_PCIE.

Signed-off-by: Dirk Eibach <eibach@gdsys.de>
---
 cpu/ppc4xx/4xx_pci.c  |    5 +++--
 cpu/ppc4xx/4xx_pcie.c |    2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/cpu/ppc4xx/4xx_pci.c b/cpu/ppc4xx/4xx_pci.c
index e8871fc..2e75886 100644
--- a/cpu/ppc4xx/4xx_pci.c
+++ b/cpu/ppc4xx/4xx_pci.c
@@ -588,8 +588,9 @@ void pci_init_board(void)
 	int busno;
 
 	busno = pci_440_init (&ppc440_hose);
-#if defined(CONFIG_440SPE) || \
-    defined(CONFIG_460EX) || defined(CONFIG_460GT)
+#if (defined(CONFIG_440SPE) || \
+    defined(CONFIG_460EX) || defined(CONFIG_460GT)) && \
+    !defined(CONFIG_PCI_DISABLE_PCIE)
 	pcie_setup_hoses(busno + 1);
 #endif
 }
diff --git a/cpu/ppc4xx/4xx_pcie.c b/cpu/ppc4xx/4xx_pcie.c
index fd40d8a..58d96bb 100644
--- a/cpu/ppc4xx/4xx_pcie.c
+++ b/cpu/ppc4xx/4xx_pcie.c
@@ -33,7 +33,7 @@
 
 #if (defined(CONFIG_440SPE) || defined(CONFIG_405EX) ||	\
     defined(CONFIG_460EX) || defined(CONFIG_460GT)) && \
-    defined(CONFIG_PCI)
+    defined(CONFIG_PCI) && !defined(CONFIG_PCI_DISABLE_PCIE)
 
 #include <asm/4xx_pcie.h>
 
-- 
1.5.6.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] ppc4xx: Make PCIE support selectable
  2009-02-03 14:15 [U-Boot] [PATCH] ppc4xx: Make PCIE support selectable Dirk Eibach
@ 2009-02-06 10:12 ` Stefan Roese
  2009-02-07 21:39 ` Wolfgang Denk
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2009-02-06 10:12 UTC (permalink / raw)
  To: u-boot

On Tuesday 03 February 2009, Dirk Eibach wrote:
> On some platforms PCIE support is not required, but would be included
> because the cpu supports it. To reduce fooprint it is now configurable
> via CONFIG_PCI_DISABLE_PCIE.

Applied to ppc4xx/master. Thanks.

BTW: Please CC me on 4xx related patches in the future. This makes it easier 
for me to spot those patches.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] ppc4xx: Make PCIE support selectable
  2009-02-03 14:15 [U-Boot] [PATCH] ppc4xx: Make PCIE support selectable Dirk Eibach
  2009-02-06 10:12 ` Stefan Roese
@ 2009-02-07 21:39 ` Wolfgang Denk
  1 sibling, 0 replies; 3+ messages in thread
From: Wolfgang Denk @ 2009-02-07 21:39 UTC (permalink / raw)
  To: u-boot

Dear Dirk Eibach,

In message <1233670521-24501-1-git-send-email-eibach@gdsys.de> you wrote:
> On some platforms PCIE support is not required, but would be included
> because the cpu supports it. To reduce fooprint it is now configurable
> via CONFIG_PCI_DISABLE_PCIE.
> 
> Signed-off-by: Dirk Eibach <eibach@gdsys.de>
> ---
>  cpu/ppc4xx/4xx_pci.c  |    5 +++--
>  cpu/ppc4xx/4xx_pcie.c |    2 +-
>  2 files changed, 4 insertions(+), 3 deletions(-)

Sorry, I'm too late with my review comment:

Please document the new CONFIG_PCI_DISABLE_PCIE in the README.


As Stefan has already pushed this into mainline, please send it as
additional patch.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Be careful what you wish for. You never know who will be listening.
                                      - Terry Pratchett, _Soul Music_

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-02-07 21:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-03 14:15 [U-Boot] [PATCH] ppc4xx: Make PCIE support selectable Dirk Eibach
2009-02-06 10:12 ` Stefan Roese
2009-02-07 21:39 ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox