From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add support W90P710 ARM SoC from Nuvoton
Date: Fri, 6 Feb 2009 23:15:35 +0100 [thread overview]
Message-ID: <20090206221535.GC1113@game.jcrosoft.org> (raw)
In-Reply-To: <f8328f7c0901202145l73227d76if86ab9a54c93360b@mail.gmail.com>
On 21:45 Tue 20 Jan , Ben Warren wrote:
> Hi Konstantin,
>
> On Tue, Jan 20, 2009 at 3:46 AM, Konstantin Vovk <ksl@kslemb.com> wrote:
>
> > Add support W90P710 ARM SoC from Nuvoton
> > Add W90P1 board based on W90P710
> >
> > Signed-off-by: Konstantin Vovk <ksl@kslemb.com>
> > ---
> > MAKEALL | 1 +
> > Makefile | 3 +
> > board/w90p1/Makefile | 52 ++++
> > board/w90p1/config.mk | 27 ++
> > board/w90p1/ide.c | 108 ++++++++
> > board/w90p1/led.c | 63 +++++
> > board/w90p1/lowlevel_init.S | 130 +++++++++
> > board/w90p1/nand.c | 101 +++++++
> > board/w90p1/u-boot.lds | 69 +++++
> > board/w90p1/w90p1.c | 96 +++++++
> > cpu/arm720t/cpu.c | 46 +++-
> > cpu/arm720t/interrupts.c | 88 ++++++-
> > cpu/arm720t/serial.c | 108 +++++++-
> > cpu/arm720t/start.S | 29 ++-
> > drivers/net/Makefile | 1 +
> > drivers/net/w90p710_eth.c | 451
> > +++++++++++++++++++++++++++++++
> > drivers/net/w90p710_eth.h | 274 +++++++++++++++++++
> > examples/Makefile | 6 +-
> > include/asm-arm/arch-arm720t/W90P710.h | 239 ++++++++++++++++
> > include/asm-arm/arch-arm720t/hardware.h | 5 +-
> > include/asm-arm/io.h | 4 +
> > include/configs/W90P1.h | 237 ++++++++++++++++
> > include/netdev.h | 1 +
>
>
> Please break this patch up into logical orthogonal parts. This is too big
> to expect anybody to wade through.
ping
will send a new version soon?
btw please check the conding style of your patch
you have too long line 80 chars max
a lot's of whitespace when tab will be needed
please add space between |, >>, >, + etc...
Best Regards,
J.
prev parent reply other threads:[~2009-02-06 22:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 11:46 [U-Boot] [PATCH] Add support W90P710 ARM SoC from Nuvoton Konstantin Vovk
2009-01-21 5:45 ` Ben Warren
2009-01-21 16:32 ` Peter Tyser
2009-02-06 22:15 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090206221535.GC1113@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox