From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] mpc8641hpcn: Use physical address in flash banks defintion
Date: Tue, 10 Feb 2009 00:32:01 +0100 [thread overview]
Message-ID: <20090209233201.358B8832E893@gemini.denx.de> (raw)
In-Reply-To: <1233614092-5480-2-git-send-email-beckyb@kernel.crashing.org>
Dear Becky Bruce,
In message <1233614092-5480-2-git-send-email-beckyb@kernel.crashing.org> you wrote:
> If the VA and PA of the flash aren't the same, the banks list
> should be initialized to hold the physical address. Correct this.
>
> Signed-off-by: Becky Bruce <beckyb@kernel.crashing.org>
> ---
> include/configs/MPC8641HPCN.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/configs/MPC8641HPCN.h b/include/configs/MPC8641HPCN.h
> index 5a83296..ceb8e54 100644
> --- a/include/configs/MPC8641HPCN.h
> +++ b/include/configs/MPC8641HPCN.h
> @@ -186,7 +186,7 @@ extern unsigned long get_board_sys_clk(unsigned long dummy);
> #define CONFIG_SYS_FLASH_BASE_PHYS (CONFIG_SYS_FLASH_BASE \
> | CONFIG_SYS_PHYS_ADDR_HIGH)
>
> -#define CONFIG_SYS_FLASH_BANKS_LIST {CONFIG_SYS_FLASH_BASE}
> +#define CONFIG_SYS_FLASH_BANKS_LIST {CONFIG_SYS_FLASH_BASE_PHYS}
>
> #define CONFIG_SYS_BR0_PRELIM (BR_PHYS_ADDR(CONFIG_SYS_FLASH_BASE_PHYS) \
> | 0x00001001) /* port size 16bit */
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A secure program has to be robust: it must be able to deal with
conditions that "can't happen", whether user input, program error or
library/etc. This is basic damage control. Buffer overflow errors
have nothing to do with security, but everything with stupidity.
-- Wietse Venema in <5cnqm3$8r9@spike.porcupine.org>
next prev parent reply other threads:[~2009-02-09 23:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 22:34 [U-Boot] [PATCH 1/2] flash/cfi_flash: Use virtual sector start address, not phys Becky Bruce
2009-02-02 22:34 ` [U-Boot] [PATCH 2/2] mpc8641hpcn: Use physical address in flash banks defintion Becky Bruce
2009-02-09 23:32 ` Wolfgang Denk [this message]
2009-02-03 8:53 ` [U-Boot] [PATCH 1/2] flash/cfi_flash: Use virtual sector start address, not phys Pieter
2009-02-03 14:48 ` Kumar Gala
2009-02-03 19:35 ` Becky Bruce
2009-02-05 10:42 ` Stefan Roese
2009-02-05 10:25 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209233201.358B8832E893@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox