From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add eth_get_dev_by_index
Date: Tue, 10 Feb 2009 21:44:40 -0500 [thread overview]
Message-ID: <200902102144.43098.vapier@gentoo.org> (raw)
In-Reply-To: <2acbd3e40902101743w5d9dc788lb05170769790103f@mail.gmail.com>
On Tuesday 10 February 2009 20:43:54 Andy Fleming wrote:
> On Tue, Feb 10, 2009 at 7:01 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Tuesday 10 February 2009 19:55:35 Andy Fleming wrote:
> >> diff --git a/include/net.h b/include/net.h
> >> index bbe0d4b..fc14615 100644
> >> --- a/include/net.h
> >> +++ b/include/net.h
> >> @@ -116,18 +116,19 @@
> >
> > looks like a lot of pointless whitespace changes when there should just
> > be 1 new line: the prototype
>
> They're not pointless, they fix it so that the lines are <= 80
> characters wide. The comments had extra spaces which made every line
> look like:
>
> foo blah /* this is a comment
> */
> foo2 blah3 /* another one
> */
>
> If people think the whitespace changes are too much, I'll move them
> into a separate patch.
throwing it in an unrelated patch looks wrong
-mike
next prev parent reply other threads:[~2009-02-11 2:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 0:55 [U-Boot] [PATCH] Add eth_get_dev_by_index Andy Fleming
2009-02-11 1:01 ` Mike Frysinger
2009-02-11 1:43 ` Andy Fleming
2009-02-11 2:44 ` Mike Frysinger [this message]
2009-02-11 11:47 ` Wolfgang Denk
2009-02-11 5:15 ` Ben Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902102144.43098.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox