[U-Boot] [PATCH 27/27] remove bi_enet*addr from global data for all arches

Wolfgang Denk
2009-02-16T21:03:36Z

Dear Mike Frysinger,

In message <200902161549.48687.vapier@gentoo.org> you wrote:
>
> > Then I don't understand what you are talking about or what your patch
> > is doing. To me it looks as if you were removing the bi_enetaddr[]
> > resp. bi_enet?addr[] from the bd_info structure.
>
> the discussion has moved on. the original patch removed the fields, but in
> the follow ups it was proposed simply renaming them. please review the
> context of each reply.

You just mentioned in one message a (IMHO silly) name
bi_padding_was_enetaddr[] which did not look to me as if you intended
to keep the funtionality.

And even renaming is BAD as it breaks compatibility with the Linux
kernel. It's bad enough that we have a binary data structure as a
critical interface, but suing different variable names for the same
fields would make it definitely worse.

Please leave that structure untouched.

This is my final statement on this issue.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The biggest difference between time and space is that you can't reuse
time. - Merrick Furst