[U-Boot] [PATCH 27/27] remove bi_enet*addr from global data for all arches

Wolfgang Denk
2009-02-16T20:14:32Z

Dear Mike Frysinger,

In message <200902161459.45065.vapier@gentoo.org> you wrote:
>
> > As mentioned before, bd_info is a binary interfwace between U-Boot and
> > the Linux kernel, and it must not be changed.
>
> i'm not talking about changing the binary aspect of it. i'm talking about
> changing the API. two completely different things.

Then I don't understand what you are talking about or what your patch
is doing. To me it looks as if you were removing the bi_enetaddr[]
resp. bi_enet?addr[] from the bd_info structure.

Such a modification is not permitted, the bd_info structure must be
kept constant and unchanged *and* the respective fields must be
correctly initialized before booting the Linux kernel.

This is mandatory.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Even if you aren't in doubt, consider the mental welfare of the per-
son who has to maintain the code after you, and who will probably put
parens in the wrong place. - Larry Wall in the perl man page