[U-Boot] [PATCH 27/27] remove bi_enet*addr from global data for all arches

Scott Wood
2009-02-16T19:00:59Z

Mike Frysinger wrote:
> On Monday 16 February 2009 13:16:38 Scott Wood wrote:
>> This will break compatibility with pre-device-tree kernels.
>>
>> bd_t is a public interface, albeit a deprecated one.
>
> the fact that the size can change based on board configs makes it already a
> pretty unreliable ABI ...

Sure, that's why it's deprecated. :-)

> at any rate, is there a define that can be keyed off of ? CONFIG_HAS_FDT or
> some such junk ? then the behavior can be changed to like:
> #ifndef CONFIG_HAS_FDT
> /* ABI compat junk */
> uchar bi_padding_was_enetaddr[6];
> #endif

Why not just leave the bd_t alone, until such a time as we can get rid
of it altogether?

Note that just because we support booting with device trees doesn't mean
we don't also support booting legacy kernels.

-Scott