[U-Boot] [PATCH 22/27] pcs440ep: get mac address from environment and move load_sernum_ethaddr() to board init

Mike Frysinger
2009-02-17T00:05:11Z

On Monday 16 February 2009 17:57:22 Wolfgang Denk wrote:
> In message Mike Frysinger wrote:
> > The environment is the canonical storage location of the mac address, so
> > we're killing off the global data location and moving everything to
> > querying the env directly.
> >
> > Move all the work of load_sernum_ethaddr() into a local load_ethaddr()
> > func and call that from misc_init_r(). We leave load_sernum_ethaddr()
> > as a stub so that it can be removed from all places in a later commit.
> >
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > CC: Stefan Roese <sr@denx.de>
> > CC: Ben Warren <biggerbadderben@gmail.com>
>
> ...
>
> > +void load_sernum_ethaddr (void)
> > +{
> > +}
> > +
>
> See previous comments - please do not add dead code just to remove it
> later.

your previous comment doesnt apply to these later ones. the first change is
for arm-only. the later changes are for ppc. it isnt dead code because the
function is still called by common ppc code. just like i outlined in the
summary for this patchset.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090216/5321d2a4/attachment.pgp