[U-Boot] [PATCH 27/27] remove bi_enet*addr from global data for all arches

Wolfgang Denk
2009-02-16T23:13:25Z

Dear Mike Frysinger,

In message <200902161618.16726.vapier@gentoo.org> you wrote:
>
> > And even renaming is BAD as it breaks compatibility with the Linux
> > kernel. It's bad enough that we have a binary data structure as a
> > critical interface, but suing different variable names for the same
> > fields would make it definitely worse.
>
> that doesnt make any sense at all. the kernel isnt passed the structure as
> seen in the C language, it gets passed a binary blob. how the kernel chooses
> to interpret it is up to the kernel.

And how do you check for problems? At least initially by comparing
the source code. Why making this more difficult than necessary?

> > Please leave that structure untouched.
> >
> > This is my final statement on this issue.
>
> you'd think the maintainer would be more open to talking about issues instead
> of closing their mind and ignoring improvements

We have discussed this here for some time now, and I considered the
pros and cons and made up my mind. YMMV.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
God is real, unless declared integer.