[U-Boot] [PATCH 22/27] pcs440ep: get mac address from environment and move load_sernum_ethaddr() to board init

Wolfgang Denk
2009-02-19T12:12:34Z

Dear Mike Frysinger,

In message <200902182046.01290.vapier@gentoo.org> you wrote:
>
> ive pushed up to my macaddr branch. the changes are:
> - rebased against latest master mainline master
> - expanded vprintf() changelog a bit
> - squashed the ppc load_sernum_ethaddr() changes into 1 commit
> - fixed the return value in eth_getenv_enetaddr()
> - fixed bugs in the net cdp code pointed out in 2nd patch series

Thanks. Unfortunately the first patch in the series (the printf
extension) breaks some board - I just did a small test and got this:

Configuring for TQM860L board...
/home/wd/git/u-boot/next/board/tqc/tqm8xx/u-boot.lds:145 cannot move
location counter backwards (from 40008088 to 40008000)
make: *** [u-boot] Error 1
ppc_8xx-size: './u-boot': No such file

Mike - do you want to fix the loader script, or do you want the board
maintainer to do that (i. e. me) ?

I think we should do these changes BEFORE appplying your patch
series (to avoid bisect issues), what do you think?

Note (especially to Jean-Christophe who asked):

I measured the size impact of the printf changes; a short scan on
seven PowerPC boards showed an average size increase of 1.6 kB:

Board Diff old new
TQM8260 1168 : 189520 190688
TQM5200 1152 : 690468 691620
ads5121 1168 : 264816 265984
ocotea 1256 : 313444 314700
sequoia 1256 : 703404 704660
MPC8572DS 1236 : 487457 488693
MPC8641HPCN 4064 : 463916 467980
AVRG: 1614

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
1st Old Man: Gee, its windy today.
2nd Old Man: No it's not... it's Thursday.
3rd Old Man: Yeh, me too. Let's go for a beer.