[U-Boot] [PATCH 22/27] pcs440ep: get mac address from environment and move load_sernum_ethaddr() to board init

Wolfgang Denk
2009-02-16T22:57:22Z

Dear Mike Frysinger,

In message <1234596190-524-23-git-send-email-vapier@gentoo.org> you wrote:
> The environment is the canonical storage location of the mac address, so
> we're killing off the global data location and moving everything to
> querying the env directly.
>
> Move all the work of load_sernum_ethaddr() into a local load_ethaddr()
> func and call that from misc_init_r(). We leave load_sernum_ethaddr()
> as a stub so that it can be removed from all places in a later commit.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> CC: Stefan Roese <sr@denx.de>
> CC: Ben Warren <biggerbadderben@gmail.com>
...
> +void load_sernum_ethaddr (void)
> +{
> +}
> +

See previous comments - please do not add dead code just to remove it
later.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I think it's a new feature. Don't tell anyone it was an accident. :-)
-- Larry Wall on s/foo/bar/eieio in <10911@jpl-devvax.JPL.NASA.GOV>