[U-Boot] [PATCH 22/27] pcs440ep: get mac address from environment and move load_sernum_ethaddr() to board init

Mike Frysinger
2009-02-18T22:17:09Z

On Tuesday 17 February 2009 08:42:01 Stefan Roese wrote:
> On Tuesday 17 February 2009, Wolfgang Denk wrote:
> > > > Well, there is a very small number of boards. Why cannot we have this
> > > > change in one step, in one commit? Adding empty functions just to
> > > > remove them later seems sub-optimal to me.
> > >
> > > in my mind, what i did is more logical. i'll do whatever way you want
> > > though. so just explicitly state "squash those changes into one even
> > > though they touch a bunch of different places" and i'll happily do it.
> >
> > Hm... maybe somebody else comments?
> >
> > Stefan, Ben?
>
> Personally I would prefer this "squashed" patch version as well. If
> possible in a "git-bisectable" version.

it would be bisectable because then there would be only one change:
- every board would move load_sernum_ethaddr() to board init (as well as any
side effects that the change requires)
- the common ppc code would stop calling load_sernum_ethaddr()

i think this is the only outstanding issue for the patchset before Ben merges
it into whatever testing tree he has ...
-mike