public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 16/27] cpu/: get mac address from environment
Date: Mon, 16 Feb 2009 18:56:59 -0500	[thread overview]
Message-ID: <200902161857.00648.vapier@gentoo.org> (raw)
In-Reply-To: <20090216225255.88DD1832E893@gemini.denx.de>

On Monday 16 February 2009 17:52:55 Wolfgang Denk wrote:
> In message Mike Frysinger wrote:
> > --- a/cpu/mpc8260/ether_scc.c
> > +++ b/cpu/mpc8260/ether_scc.c
> > @@ -199,6 +199,7 @@ static int sec_init(struct eth_device *dev, bd_t
> > *bis) volatile immap_t *immr = (immap_t *)CONFIG_SYS_IMMR;
> >      scc_enet_t *pram_ptr;
> >      uint dpaddr;
> > +	uchar ea[6];
> >
> >      rxIdx = 0;
> >      txIdx = 0;
> > @@ -261,11 +262,10 @@ static int sec_init(struct eth_device *dev, bd_t
> > *bis) pram_ptr->sen_gaddr3 = 0x0;   /* Group Address Filter 3 (unused) */
> > pram_ptr->sen_gaddr4 = 0x0;   /* Group Address Filter 4 (unused) */
> >
> > -#  define ea bis->bi_enetaddr
> > +	eth_getenv_enetaddr("ethaddr", ea);
> >      pram_ptr->sen_paddrh = (ea[5] << 8) + ea[4];
> >      pram_ptr->sen_paddrm = (ea[3] << 8) + ea[2];
> >      pram_ptr->sen_paddrl = (ea[1] << 8) + ea[0];
> > -#  undef ea
>
> I see that we have bad indentations here, but please either provide a
> separate patch to fix the cosing style, or stich with your new code to
> the existing one.

oh, looks like this file uses sucky GNU style.  i didnt notice as i use 4-
spaced tabs.  i'll just change my tabs to match existing style as the cleanup 
would pretty much rewrite the whole file.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090216/58b8c8e2/attachment.pgp 

  reply	other threads:[~2009-02-16 23:56 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-14  7:22 [U-Boot] [PATCH 00/27] standardize mac address handling in u-boot Mike Frysinger
2009-02-14  7:22 ` [U-Boot] [PATCH 01/27] net: new utility functions for working with enetaddr's Mike Frysinger
2009-02-16 22:28   ` Wolfgang Denk
2009-02-17  0:00     ` Mike Frysinger
2009-02-17  0:13       ` Wolfgang Denk
2009-02-17  0:20         ` Mike Frysinger
2009-02-17  0:26           ` Scott Wood
2009-02-17  0:29           ` Wolfgang Denk
2009-02-17  0:37             ` Mike Frysinger
2009-02-17  7:31               ` Wolfgang Denk
2009-02-14  7:22 ` [U-Boot] [PATCH 02/27] doc/README.enetaddr: document proper MAC usage Mike Frysinger
2009-02-16 22:38   ` Wolfgang Denk
2009-02-17  0:12     ` Mike Frysinger
2009-02-14  7:22 ` [U-Boot] [PATCH 03/27] Blackfin: bfin_mac: force boards to setup the MAC themselves Mike Frysinger
2009-02-14  7:22 ` [U-Boot] [PATCH 04/27] net: get mac address from environment and use eth util funcs Mike Frysinger
2009-02-14  7:22 ` [U-Boot] [PATCH 05/27] bdinfo: get mac address from environment Mike Frysinger
2009-02-14  7:22 ` [U-Boot] [PATCH 06/27] bootvx: " Mike Frysinger
2009-02-14  7:22 ` [U-Boot] [PATCH 07/27] lynxkdi: " Mike Frysinger
2009-02-14  7:22 ` [U-Boot] [PATCH 08/27] nvedit: do not update global bi_enetaddr and do not call eth_set_enetaddr() Mike Frysinger
2009-02-14  7:22 ` [U-Boot] [PATCH 09/27] AmigaOneG3SE/enet: get mac address from environment Mike Frysinger
2009-02-14  7:22 ` [U-Boot] [PATCH 10/27] boards: " Mike Frysinger
2009-02-16 22:46   ` Wolfgang Denk
2009-02-16 23:55     ` Mike Frysinger
2009-02-14  7:22 ` [U-Boot] [PATCH 11/27] drivers/net/: " Mike Frysinger
2009-02-14  7:22 ` [U-Boot] [PATCH 12/27] bcm570x: " Mike Frysinger
2009-02-14  7:22 ` [U-Boot] [PATCH 13/27] cs8900: " Mike Frysinger
2009-02-14  7:22 ` [U-Boot] [PATCH 14/27] sh_eth: " Mike Frysinger
2009-02-14  7:22 ` [U-Boot] [PATCH 15/27] lan91c96/smc91111/smc911x: " Mike Frysinger
2009-02-14  7:22 ` [U-Boot] [PATCH 16/27] cpu/: " Mike Frysinger
2009-02-16 22:52   ` Wolfgang Denk
2009-02-16 23:56     ` Mike Frysinger [this message]
2009-02-14  7:23 ` [U-Boot] [PATCH 17/27] npe: " Mike Frysinger
2009-02-14  7:23 ` [U-Boot] [PATCH 18/27] lib_*/board.c: do not initialize bi_enet*addr in global data Mike Frysinger
2009-02-14  7:23 ` [U-Boot] [PATCH 19/27] nx823: get mac address from environment Mike Frysinger
2009-02-14  7:23 ` [U-Boot] [PATCH 20/27] arm: " Mike Frysinger
2009-02-14  7:23 ` [U-Boot] [PATCH 21/27] cmc_pu2: " Mike Frysinger
2009-02-16 22:56   ` Wolfgang Denk
2009-02-17  0:03     ` Mike Frysinger
2009-02-14  7:23 ` [U-Boot] [PATCH 22/27] pcs440ep: get mac address from environment and move load_sernum_ethaddr() to board init Mike Frysinger
2009-02-16 22:57   ` Wolfgang Denk
2009-02-17  0:05     ` Mike Frysinger
2009-02-17  0:16       ` Wolfgang Denk
2009-02-17  0:22         ` Mike Frysinger
2009-02-17  0:31           ` Wolfgang Denk
2009-02-17 13:42             ` Stefan Roese
2009-02-18 22:17               ` Mike Frysinger
2009-02-18 22:36                 ` Wolfgang Denk
2009-02-18 22:41                   ` Ben Warren
2009-02-18 22:49                   ` Mike Frysinger
2009-02-18 22:54                     ` Wolfgang Denk
2009-02-19  0:06                     ` Wolfgang Denk
2009-02-19  1:45                       ` Mike Frysinger
2009-02-19 12:12                         ` Wolfgang Denk
2009-02-19 12:31                           ` Jean-Christophe PLAGNIOL-VILLARD
2009-02-19 12:52                           ` Wolfgang Denk
2009-02-19 13:08                         ` Wolfgang Denk
2009-02-14  7:23 ` [U-Boot] [PATCH 23/27] kup4k/kup4x: rename load_sernum_ethaddr() to kup_load_sernum_ethaddr() Mike Frysinger
2009-02-16 22:58   ` Wolfgang Denk
2009-02-14  7:23 ` [U-Boot] [PATCH 24/27] tqm8xx: rename load_sernum_ethaddr() to tqc_load_sernum_ethaddr() Mike Frysinger
2009-02-16 22:58   ` Wolfgang Denk
2009-02-14  7:23 ` [U-Boot] [PATCH 25/27] ppc: do not initialize bi_enet*addr in global data Mike Frysinger
2009-02-14  7:23 ` [U-Boot] [PATCH 26/27] drop now unused load_sernum_ethaddr() function Mike Frysinger
2009-02-14  9:22   ` Jean-Christophe PLAGNIOL-VILLARD
2009-02-14 18:03     ` Mike Frysinger
2009-02-16 22:58   ` Wolfgang Denk
2009-02-14  7:23 ` [U-Boot] [PATCH 27/27] remove bi_enet*addr from global data for all arches Mike Frysinger
2009-02-16 18:16   ` Scott Wood
2009-02-16 18:57     ` Mike Frysinger
2009-02-16 19:00       ` Scott Wood
2009-02-16 19:29         ` Mike Frysinger
2009-02-16 19:47           ` Wolfgang Denk
2009-02-16 19:59             ` Mike Frysinger
2009-02-16 20:14               ` Wolfgang Denk
2009-02-16 20:49                 ` Mike Frysinger
2009-02-16 20:54                   ` Scott Wood
2009-02-16 21:13                     ` Mike Frysinger
2009-02-16 21:03                   ` Wolfgang Denk
2009-02-16 21:18                     ` Mike Frysinger
2009-02-16 23:13                       ` Wolfgang Denk
2009-02-17  0:18                         ` Mike Frysinger
2009-02-17  0:27                           ` Wolfgang Denk
2009-02-17  1:49                           ` Kim Phillips
2009-02-17  3:24                             ` Mike Frysinger
2009-02-16 19:24       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902161857.00648.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox