From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Frysinger <vapier@gentoo.org>
Date: Mon, 16 Feb 2009 19:22:42 -0500
Subject: [U-Boot] [PATCH 22/27] pcs440ep: get mac address from
	environment and move load_sernum_ethaddr() to board init
In-Reply-To: <20090217001613.F3D5B832E893@gemini.denx.de>
References: <1234596190-524-1-git-send-email-vapier@gentoo.org>
	<200902161905.12952.vapier@gentoo.org>
	<20090217001613.F3D5B832E893@gemini.denx.de>
Message-ID: <200902161922.44211.vapier@gentoo.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday 16 February 2009 19:16:13 Wolfgang Denk wrote:
> In message Mike wrote:
> > > > +void load_sernum_ethaddr (void)
> > > > +{
> > > > +}
> > > > +
> > >
> > > See previous comments - please do not add dead code just to remove it
> > > later.
> >
> > your previous comment doesnt apply to these later ones.  the first change
> > is for arm-only.  the later changes are for ppc.  it isnt dead code
> > because the function is still called by common ppc code.  just like i
> > outlined in the summary for this patchset.
>
> Well, there is a very small number of boards. Why cannot we have this
> change in one step, in one commit? Adding empty functions just to
> remove them later seems sub-optimal to me.

in my mind, what i did is more logical.  i'll do whatever way you want though.  
so just explicitly state "squash those changes into one even though they touch 
a bunch of different places" and i'll happily do it.
-mike