public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] 1/12 Multiadapter/multibus I2C, common part 1
Date: Mon, 16 Feb 2009 22:38:37 +0100	[thread overview]
Message-ID: <20090216213837.6CB61832E893@gemini.denx.de> (raw)
In-Reply-To: <Pine.LNX.4.64ksi.0902121409460.21067@home-gw.koi8.net>

Dear ksi at koi8.net,

In message <Pine.LNX.4.64ksi.0902121409460.21067@home-gw.koi8.net> you wrote:
> Signed-off-by: Sergey Kubushyn <ksi@koi8.net>
> ---
> diff -purN u-boot-i2c.orig/common/cmd_date.c u-boot-i2c/common/cmd_date.c
> --- u-boot-i2c.orig/common/cmd_date.c	2009-02-12 10:43:41.000000000 -0800
> +++ u-boot-i2c/common/cmd_date.c	2009-02-12 10:46:00.000000000 -0800
> @@ -46,8 +46,13 @@ int do_date (cmd_tbl_t *cmdtp, int flag,
>  	int old_bus;

One more global comment: can you please use git and especially
git-format-patch to prepare your patches? For example, it is really
helpful to see at a glance which files are affected by a patch.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I've seen it. It's rubbish."          - Marvin the Paranoid Android

  parent reply	other threads:[~2009-02-16 21:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12 22:12 [U-Boot] [PATCH] 1/12 Multiadapter/multibus I2C, common part 1 ksi at koi8.net
2009-02-13  8:03 ` Heiko Schocher
2009-02-13 17:51   ` Jon Loeliger
2009-02-14  8:24     ` Heiko Schocher
2009-02-16 21:36     ` Wolfgang Denk
2009-02-16 21:34 ` Wolfgang Denk
2009-02-17  6:04   ` ksi at koi8.net
2009-02-16 21:38 ` Wolfgang Denk [this message]
2009-02-17 18:25   ` ksi at koi8.net

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090216213837.6CB61832E893@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox