public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kim Phillips <kim.phillips@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 08/12] 83xx, kmeter: QE_ENET10 errata for Silicon Revision 2.1
Date: Tue, 17 Feb 2009 19:25:50 -0600	[thread overview]
Message-ID: <20090217192550.45e60b6a.kim.phillips@freescale.com> (raw)
In-Reply-To: <499A7B5B.4030709@denx.de>

On Tue, 17 Feb 2009 09:54:51 +0100
Heiko Schocher <hs@denx.de> wrote:

> ppc_82xx-ld: NAND bootstrap too big
> ppc_82xx-ld: NAND bootstrap too big
> make[1]: *** [/home/hs/U-Boot-Patches/u-boot/nand_spl/u-boot-spl] Fehler 1
> make: *** [nand_spl] Fehler 2
> make: *** Warte auf noch nicht beendete Prozesse...
> ppc_82xx-size: './u-boot': No such file
> [hs at pollux u-boot]$
> 
> I get this error just with actual u-boot.

now that I've verified it, I see it too.  I bisected it:

bced7ccefa08512c54a6d146658ff7dbc33d5dfe is first bad commit
commit bced7ccefa08512c54a6d146658ff7dbc33d5dfe
Author: Kumar Gala <galak@kernel.crashing.org>
Date:   Fri Feb 6 08:08:06 2009 -0600

    ppc: Fix roll over bug in flush_cache()
    
    If we call flush_cache(0xfffff000, 0x1000) it would never
    terminate the loop since end = 0xffffffff and we'd roll over
    our counter from 0xfffffe0 to 0 (assuming a 32-byte cache line)
    
    Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

the extra checks this patch makes makes flush_cache() consume a mere 16
more bytes, which makes the SIMPC8313 build fail.

I don't see an easy way out of this that satisfies everyone.  Ideas?

Kim

  reply	other threads:[~2009-02-18  1:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 18:26 [U-Boot] [PATCH 08/12] 83xx, kmeter: QE_ENET10 errata for Silicon Revision 2.1 Heiko Schocher
2009-02-17  1:37 ` Kim Phillips
2009-02-17  7:07   ` Heiko Schocher
2009-02-17  8:54     ` Heiko Schocher
2009-02-18  1:25       ` Kim Phillips [this message]
2009-02-18  2:29         ` Kumar Gala
2009-02-18  3:30           ` Kumar Gala
2009-02-18 17:20         ` Scott Wood
2009-02-18 18:25           ` Kim Phillips
2009-02-17 17:51   ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090217192550.45e60b6a.kim.phillips@freescale.com \
    --to=kim.phillips@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox