From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Pad data length for nand write
Date: Tue, 17 Feb 2009 21:22:01 +0100 [thread overview]
Message-ID: <20090217202201.12E23832E893@gemini.denx.de> (raw)
In-Reply-To: <499B03FD.7050207@siconix.com>
Dear Derek Ou,
In message <499B03FD.7050207@siconix.com> you wrote:
>
> Until v1.3.4, "nand write.jffs2" supports non page-aligned data write and
> pad data automatically to page alignment. As a result, we can use the
> following scripts to automate downloading a file and writing it to flash.
> "tftp file.bin" and "nand write.jffs2 add_# off_# $(filesize)"
> But in the later releases, this feature was no longer supported. So my
> patch restores this feature to nand write command.
Such implicit padding is IMHO a bad idea.
I think we should rather add logic similar to what we use on NOR flash
and support a "+length" syntax which indicates "please round up to the
next block boundary".
You would then write
nand write.jffs2 addr off +${filesize}
to get the wanted behaviour.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A rolling stone gathers momentum.
prev parent reply other threads:[~2009-02-17 20:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-17 17:15 [U-Boot] [PATCH] Pad data length for nand write Derek Ou
2009-02-17 17:15 ` Derek Ou
2009-02-17 18:51 ` Scott Wood
2009-02-17 20:54 ` Derek Ou
2009-02-17 21:16 ` Scott Wood
2009-02-17 21:37 ` Derek Ou
2009-02-17 17:55 ` Mike Frysinger
2009-02-17 18:37 ` Derek Ou
2009-02-17 18:41 ` Scott Wood
2009-02-17 20:22 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090217202201.12E23832E893@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox