From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fuchs <mfuchs@ma-fu.de>
Date: Wed, 18 Feb 2009 07:46:54 +0100
Subject: [U-Boot] [PATCH] ppc4xx: Cleanup PMC405 board support
In-Reply-To: <200902171554.14147.matthias.fuchs@esd.eu>
References: <200902152226.55468.matthias.fuchs@esd.eu>
	<200902171519.28995.sr@denx.de>
	<200902171554.14147.matthias.fuchs@esd.eu>
Message-ID: <200902180746.57288.mfuchs@ma-fu.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefan,
> On Tuesday 17 February 2009 15:19, Stefan Roese wrote:
> > On Sunday 15 February 2009, Matthias Fuchs wrote:
> > > This patch fixes coding style for PMC405 board support.
> > > Also some unneeded features/code is removed.
> > 
> > Please find some comments below.
> > 
> > > +	out32(GPIO0_TCR, CONFIG_SYS_FPGA_PRG | CONFIG_SYS_FPGA_CLK | \
> > > +	      CONFIG_SYS_FPGA_DATA | CONFIG_SYS_XEREADY);
> > 
> > I suggest to switch to using the out_be32()/in_be32() accessor functions 
> > instead. I am aware that many other 4xx boards still use the "wrong" accessor 
> > functions for initial GPIO configuration. I'll try to change this soon.
> 
> You are right I missed these. I will update the patch and resend.
> I will also fix the other esd boards in the next days.
please take a look at my 2nd patch ("Update PMC405 ...."). It does the
requested accessor fixes. So my first patch does nothing by style cleanup while
 the 2nd one brings some updates. I tried  not to mix up beautyfication with
functional code changes :-) So please keep these patches as they are :-)

Matthias