From: Kim Phillips <kim.phillips@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Create configuration option for restricted ns16550 functions
Date: Wed, 18 Feb 2009 14:01:59 -0600 [thread overview]
Message-ID: <20090218140159.e4880db0.kim.phillips@freescale.com> (raw)
In-Reply-To: <20090218182927.DBC1D832E43F@gemini.denx.de>
On Wed, 18 Feb 2009 19:29:27 +0100
Wolfgang Denk <wd@denx.de> wrote:
> > +#else
> > +char NS16550_getc (NS16550_t com_port) { }
> > +int NS16550_tstc (NS16550_t com_port) { }
>
> If these functions are supposed to return "char" resp. "int", you will
> get casty compiler warnings with an empty function body.
I didn't see them, but anyway, please consider this patch (u-boot-spl
is 32 bytes smaller than previous empty-fn-body based patch):
next prev parent reply other threads:[~2009-02-18 20:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-17 20:14 [U-Boot] [PATCH v2] Create configuration option for restricted ns16550 functions Ron Madrid
2009-02-18 18:21 ` Kim Phillips
2009-02-18 18:12 ` Scott Wood
2009-02-18 18:29 ` Wolfgang Denk
2009-02-18 20:01 ` Kim Phillips [this message]
2009-02-18 19:54 ` Scott Wood
2009-02-18 20:02 ` Ron Madrid
2009-02-18 20:45 ` Kim Phillips
2009-02-18 22:11 ` Wolfgang Denk
2009-02-18 23:23 ` Kim Phillips
2009-02-18 23:36 ` Wolfgang Denk
2009-02-18 18:30 ` Kim Phillips
2009-02-18 19:02 ` Ron Madrid
2009-02-18 21:58 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090218140159.e4880db0.kim.phillips@freescale.com \
--to=kim.phillips@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox