public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kim Phillips <kim.phillips@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] MPC8349ITX: several config issues fixed
Date: Wed, 18 Feb 2009 15:20:03 -0600	[thread overview]
Message-ID: <20090218152003.b418810d.kim.phillips@freescale.com> (raw)
In-Reply-To: <ed82fe3e0902171354j50b4f261q2fb9f330240c8f21@mail.gmail.com>

On Tue, 17 Feb 2009 15:54:52 -0600
Timur Tabi <timur@freescale.com> wrote:

> On Tue, Feb 17, 2009 at 3:49 PM, Kumar Gala <galak@kernel.crashing.org> wrote:
> > The default value is 256M so I don't thing the change is need anymore.
> 
> Huh?  I think his patch is supposed to address the fact that 256MB is
> the limit, and he wants to add more.

so this commit started producing warnings for boards that defined their
own CONFIG_MAX_MEM_MAPPED, such as the SIMPC8313 (with 512MB):

commit 87c9063963561d3d01064be34d0c30855a56587b
Author: Kumar Gala <galak@kernel.crashing.org>
Date:   Thu Feb 5 20:40:58 2009 -0600

    ppc: Move CONFIG_MAX_MEM_MAPPED to common config.h
    
    Moved CONFIG_MAX_MEM_MAPPED to the asm/config.h so its kept consistent
    between the two current users (lib_ppc/board.c, 44x SPD DDR2).
    
    Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
    Acked-by: Stefan Roese <sr@denx.de>

the warnings are:

In file included from /home/r1aaha/git/u-boot/include/config.h:5,
                 from /home/r1aaha/git/u-boot/include/common.h:35,
                 from simpc8313.c:26:
/home/r1aaha/git/u-boot/include/configs/SIMPC8313.h:81:1: warning: "CONFIG_MAX_MEM_MAPPED" redefined
In file included from /home/r1aaha/git/u-boot/include/config.h:4,
                 from /home/r1aaha/git/u-boot/include/common.h:35,
                 from simpc8313.c:26:
/home/r1aaha/git/u-boot/include/asm/config.h:28:1: warning: this is the location of the previous definition

which is probably all due to include/config.h including the file with
the default value prior to the board's config:

/* Automatically generated - do not edit */
#include <asm/config.h>
#include <configs/SIMPC8313.h>

So how are boards supposed to define their own CONFIG_MAX_MEM_MAPPED
now?  In the Makefile?  Or is there a better place for this default
value?

Kim

  reply	other threads:[~2009-02-18 21:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-04 16:27 [U-Boot] [PATCH v3] MPC8349ITX: several config issues fixed Valeriy Glushkov
2009-02-17  1:28 ` Kim Phillips
2009-02-17 16:31   ` Timur Tabi
2009-02-17 21:49     ` Kumar Gala
2009-02-17 21:54       ` Timur Tabi
2009-02-18 21:20         ` Kim Phillips [this message]
2009-02-18 21:28           ` Kumar Gala
2009-03-06  0:45   ` Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090218152003.b418810d.kim.phillips@freescale.com \
    --to=kim.phillips@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox