From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/7] mpc83xx: MPC837XEMDS: Initialize SerDes before negating PCIE reset signal
Date: Thu, 19 Feb 2009 18:20:39 +0300 [thread overview]
Message-ID: <20090219152039.GA19823@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090219151943.GA3310@oksana.dev.rtsoft.ru>
The SerDes initialization should be finished before negating the reset
signal according to the reference manual. This isn't an issue on real
hardware, but we'd better stick to the specifications anyway.
Suggested-by: Liu Dave <DaveLiu@freescale.com>
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
board/freescale/mpc837xemds/pci.c | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/board/freescale/mpc837xemds/pci.c b/board/freescale/mpc837xemds/pci.c
index 31116b3..29de2e7 100644
--- a/board/freescale/mpc837xemds/pci.c
+++ b/board/freescale/mpc837xemds/pci.c
@@ -115,6 +115,13 @@ skip_pci:
if (PARTID_NO_E(spridr) == SPR_8379)
return;
+ if (pex2)
+ fsl_setup_serdes(CONFIG_FSL_SERDES2, FSL_SERDES_PROTO_PEX_X2,
+ FSL_SERDES_CLK_100, FSL_SERDES_VDD_1V);
+ else
+ fsl_setup_serdes(CONFIG_FSL_SERDES2, FSL_SERDES_PROTO_PEX,
+ FSL_SERDES_CLK_100, FSL_SERDES_VDD_1V);
+
/* Configure the clock for PCIE controller */
clrsetbits_be32(&clk->sccr, SCCR_PCIEXP1CM | SCCR_PCIEXP2CM,
SCCR_PCIEXP1CM_1 | SCCR_PCIEXP2CM_1);
@@ -132,13 +139,6 @@ skip_pci:
out_be32(&pcie_law[1].bar, CONFIG_SYS_PCIE2_BASE & LAWBAR_BAR);
out_be32(&pcie_law[1].ar, LBLAWAR_EN | LBLAWAR_512MB);
- if (pex2)
- fsl_setup_serdes(CONFIG_FSL_SERDES2, FSL_SERDES_PROTO_PEX_X2,
- FSL_SERDES_CLK_100, FSL_SERDES_VDD_1V);
- else
- fsl_setup_serdes(CONFIG_FSL_SERDES2, FSL_SERDES_PROTO_PEX,
- FSL_SERDES_CLK_100, FSL_SERDES_VDD_1V);
-
mpc83xx_pcie_init(pex2 ? 1 : 2, pcie_reg, 0);
}
--
1.5.6.5
next prev parent reply other threads:[~2009-02-19 15:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 15:19 [U-Boot] [PATCH 0/7] Some PCIe patches for MPC83xx Anton Vorontsov
2009-02-19 15:20 ` Anton Vorontsov [this message]
2009-02-19 15:20 ` [U-Boot] [PATCH 2/7] PCI: Add pci_last_busno() helper Anton Vorontsov
2009-02-19 15:20 ` [U-Boot] [PATCH 3/7] mpc83xx: PCIe: Don't start bus enumeration at 0 Anton Vorontsov
2009-02-19 15:20 ` [U-Boot] [PATCH 4/7] mpc83xx: PCIe: Fix CONFIG_PCI_SCAN_SHOW reporting bogus values Anton Vorontsov
2009-02-19 15:20 ` [U-Boot] [PATCH 5/7] mpc83xx: PCI: Fix bus-range fdt fixups for PCI1 controllers Anton Vorontsov
2009-02-19 15:20 ` [U-Boot] [PATCH 6/7] mpc83xx: PCI: Fix hard-coded first_busno value Anton Vorontsov
2009-02-19 15:20 ` [U-Boot] [PATCH 7/7] mpc83xx: MPC837XERDB: Add PCIe support Anton Vorontsov
2009-02-23 23:33 ` [U-Boot] [PATCH 0/7] Some PCIe patches for MPC83xx Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090219152039.GA19823@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox