From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/7] mpc83xx: PCIe: Fix CONFIG_PCI_SCAN_SHOW reporting bogus values
Date: Thu, 19 Feb 2009 18:20:44 +0300 [thread overview]
Message-ID: <20090219152044.GD19823@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090219151943.GA3310@oksana.dev.rtsoft.ru>
This patch fixes an issue in config space read accessors: we should
fill-in the value even if we fail (e.g. skipping devices), otherwise
CONFIG_PCI_SCAN_SHOW reports bogus values during boot up.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
cpu/mpc83xx/pcie.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/cpu/mpc83xx/pcie.c b/cpu/mpc83xx/pcie.c
index 1a3b2be..77f8906 100644
--- a/cpu/mpc83xx/pcie.c
+++ b/cpu/mpc83xx/pcie.c
@@ -60,6 +60,9 @@ static int mpc83xx_pcie_remap_cfg(struct pci_controller *hose, pci_dev_t dev)
#define cfg_write(val, addr, type, op) \
do { op((type *)(addr), (val)); } while (0)
+#define cfg_read_err(val) do { *val = -1; } while (0)
+#define cfg_write_err(val) do { } while (0)
+
#define PCIE_OP(rw, size, type, op) \
static int pcie_##rw##_config_##size(struct pci_controller *hose, \
pci_dev_t dev, int offset, \
@@ -68,8 +71,10 @@ static int pcie_##rw##_config_##size(struct pci_controller *hose, \
int ret; \
\
ret = mpc83xx_pcie_remap_cfg(hose, dev); \
- if (ret) \
- return ret; \
+ if (ret) { \
+ cfg_##rw##_err(val); \
+ return ret; \
+ } \
cfg_##rw(val, (void *)hose->cfg_addr + offset, type, op); \
return 0; \
}
--
1.5.6.5
next prev parent reply other threads:[~2009-02-19 15:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 15:19 [U-Boot] [PATCH 0/7] Some PCIe patches for MPC83xx Anton Vorontsov
2009-02-19 15:20 ` [U-Boot] [PATCH 1/7] mpc83xx: MPC837XEMDS: Initialize SerDes before negating PCIE reset signal Anton Vorontsov
2009-02-19 15:20 ` [U-Boot] [PATCH 2/7] PCI: Add pci_last_busno() helper Anton Vorontsov
2009-02-19 15:20 ` [U-Boot] [PATCH 3/7] mpc83xx: PCIe: Don't start bus enumeration at 0 Anton Vorontsov
2009-02-19 15:20 ` Anton Vorontsov [this message]
2009-02-19 15:20 ` [U-Boot] [PATCH 5/7] mpc83xx: PCI: Fix bus-range fdt fixups for PCI1 controllers Anton Vorontsov
2009-02-19 15:20 ` [U-Boot] [PATCH 6/7] mpc83xx: PCI: Fix hard-coded first_busno value Anton Vorontsov
2009-02-19 15:20 ` [U-Boot] [PATCH 7/7] mpc83xx: MPC837XERDB: Add PCIe support Anton Vorontsov
2009-02-23 23:33 ` [U-Boot] [PATCH 0/7] Some PCIe patches for MPC83xx Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090219152044.GD19823@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox