public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/7] mpc83xx: PCI: Fix hard-coded first_busno value
Date: Thu, 19 Feb 2009 18:20:50 +0300	[thread overview]
Message-ID: <20090219152050.GF19823@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090219151943.GA3310@oksana.dev.rtsoft.ru>

We should use pci_last_busno() in pci_init_bus(), otherwise we'll
erroneously re-use PCI0's first_busno for PCI1 hoses.

NOTE: The patch is untested. All MPC83xx FSL boards I have have
PCI1 in miniPCI form, for which I don't have any cards handy.

But looking in cpu/mpc85xx/pci.c:
...
#ifdef CONFIG_MPC85XX_PCI2
        hose = &pci_hose[1];

        hose->first_busno = pci_hose[0].last_busno + 1;

And considering that we do the same for MPC83xx PCI-E support,
I think this patch is correct.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 cpu/mpc83xx/pci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cpu/mpc83xx/pci.c b/cpu/mpc83xx/pci.c
index 8f5017c..a42b230 100644
--- a/cpu/mpc83xx/pci.c
+++ b/cpu/mpc83xx/pci.c
@@ -91,7 +91,7 @@ static void pci_init_bus(int bus, struct pci_region *reg)
 	hose->regions[i].size = gd->ram_size;
 	hose->regions[i].flags = PCI_REGION_MEM | PCI_REGION_SYS_MEMORY;
 
-	hose->first_busno = 0;
+	hose->first_busno = pci_last_busno() + 1;
 	hose->last_busno = 0xff;
 
 	pci_setup_indirect(hose, CONFIG_SYS_IMMR + 0x8300 + bus * 0x80,
-- 
1.5.6.5

  parent reply	other threads:[~2009-02-19 15:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-19 15:19 [U-Boot] [PATCH 0/7] Some PCIe patches for MPC83xx Anton Vorontsov
2009-02-19 15:20 ` [U-Boot] [PATCH 1/7] mpc83xx: MPC837XEMDS: Initialize SerDes before negating PCIE reset signal Anton Vorontsov
2009-02-19 15:20 ` [U-Boot] [PATCH 2/7] PCI: Add pci_last_busno() helper Anton Vorontsov
2009-02-19 15:20 ` [U-Boot] [PATCH 3/7] mpc83xx: PCIe: Don't start bus enumeration at 0 Anton Vorontsov
2009-02-19 15:20 ` [U-Boot] [PATCH 4/7] mpc83xx: PCIe: Fix CONFIG_PCI_SCAN_SHOW reporting bogus values Anton Vorontsov
2009-02-19 15:20 ` [U-Boot] [PATCH 5/7] mpc83xx: PCI: Fix bus-range fdt fixups for PCI1 controllers Anton Vorontsov
2009-02-19 15:20 ` Anton Vorontsov [this message]
2009-02-19 15:20 ` [U-Boot] [PATCH 7/7] mpc83xx: MPC837XERDB: Add PCIe support Anton Vorontsov
2009-02-23 23:33 ` [U-Boot] [PATCH 0/7] Some PCIe patches for MPC83xx Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090219152050.GF19823@oksana.dev.rtsoft.ru \
    --to=avorontsov@ru.mvista.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox