From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Fri, 20 Feb 2009 12:02:22 -0500 Subject: [U-Boot] [PATCH] Cleanup the comment for m68k linux boot argument passing. In-Reply-To: <499EDB7E.6050501@RuggedCom.com> References: <4995A673.9070109@RuggedCom.com> <499EDB7E.6050501@RuggedCom.com> Message-ID: <200902201202.24598.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 20 February 2009 11:34:06 Richard Retanubun wrote: > From e2e085f8b8e638762c59b0bc5376b241b0046132 Mon Sep 17 00:00:00 2001 > From: Richard Retanubun > Date: Fri, 20 Feb 2009 11:06:36 -0500 > Subject: [PATCH] Cleanup the comment for m68k linux boot argument passing. > > > Signed-off-by: Richard Retanubun > --- > Hi Tsi-Chung, > > Thanks for the response, I found the solution after using a hw debugger to > step through the code. The one gotcha here is that the assembly instruction > that the compiler uses to jump to the kernel is 'jsr' which puts the next > instruction after the jsr into the stack pointer so there is an > 'off-by-one' effect from the stack pointer. > > This patch cleans up the comment to clarify the boot arg passing. > I'll try to push a patch for the kernel as well. comments for the changelog go above the ---, not below use git and put it into the commit message: $ git commit --amend blah blah the patch summary a paragraph about the changes .... -mike