public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] smc911x: split out useful defines/functions into local header
Date: Mon, 23 Feb 2009 10:47:27 -0500	[thread overview]
Message-ID: <200902231047.29402.vapier@gentoo.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0902231641440.5100@axis700.grange>

On Monday 23 February 2009 10:44:04 Guennadi Liakhovetski wrote:
> On Mon, 23 Feb 2009, Mike Frysinger wrote:
> > The smc911x driver has a lot of useful defines/functions which can be
> > used by pieces of code (such as example eeprom programmers).  Rather than
> > forcing each place to duplicate these defines/functions, split them out
> > of the smdc911x driver into a local header.
> >
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > CC: Sascha Hauer <s.hauer@pengutronix.de>
> > CC: Guennadi Liakhovetski <lg@denx.de>
> > CC: Magnus Lilja <lilja.magnus@gmail.com>
> > CC: Ben Warren <biggerbadderben@gmail.com>
>
> Hm, sorry, have any of those other "pieces of code" been posted to the
> list?  I'd like to have a look at them to see what they need all those
> register definitions for.

it's already been posted in this thread (and Ben has merged it).  but to 
answer your question, external code doesnt generally need most of those 
register definitions.  they're moved because they belong in a header file and 
because it doesnt make sense to move just a few.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090223/8e3704bc/attachment.pgp 

  reply	other threads:[~2009-02-23 15:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-22  7:56 [U-Boot] [PATCH 1/2] smc911x: split out useful defines/functions into local header Mike Frysinger
2008-12-22  7:56 ` [U-Boot] [PATCH 2/2] smc911x_eeprom: new example app for managing newer SMC parts Mike Frysinger
2009-01-05 15:17   ` Magnus Lilja
2009-01-05 15:23   ` Magnus Lilja
2009-02-17 23:35   ` Wolfgang Denk
2009-01-05 15:13 ` [U-Boot] [PATCH 1/2] smc911x: split out useful defines/functions into local header Magnus Lilja
2009-01-06 16:34   ` [U-Boot] [PATCH v2] " Mike Frysinger
2009-02-17 23:37     ` Wolfgang Denk
2009-02-23  6:56     ` Ben Warren
2009-02-23 15:29       ` [U-Boot] [PATCH v3] " Mike Frysinger
2009-02-23 15:44         ` Guennadi Liakhovetski
2009-02-23 15:47           ` Mike Frysinger [this message]
2009-02-23 16:09             ` Guennadi Liakhovetski
2009-02-25  7:17         ` Ben Warren
2009-02-25  8:01           ` Wolfgang Denk
2009-02-25  8:00         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902231047.29402.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox