From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] netloop: updates for NetLoop
Date: Wed, 25 Feb 2009 12:01:44 -0500 [thread overview]
Message-ID: <200902251201.45611.vapier@gentoo.org> (raw)
In-Reply-To: <49A53C4D.5060907@denx.de>
On Wednesday 25 February 2009 07:40:45 Heiko Schocher wrote:
> +/*
> + * This variable is incremented on each do_setenv (), so it can
> + * be used as an indication, if the environment has changed or not.
> + * So it is possible to reread an environment variable only if the
> + * environment was changed ... done so for example in NetInitLoop()
> + */
i would tweak it to say "... it can be used via get_env_id() as an ..."
> - return 0;
> + return;
> }
a return at the end of a function is pointless imo. just delete it.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090225/0c8747d6/attachment.pgp
next prev parent reply other threads:[~2009-02-25 17:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 12:40 [U-Boot] [PATCH] netloop: updates for NetLoop Heiko Schocher
2009-02-25 17:01 ` Mike Frysinger [this message]
2009-02-26 7:16 ` [U-Boot] [PATCH v2] " Heiko Schocher
2009-02-26 8:47 ` Mike Frysinger
2009-04-03 21:57 ` Wolfgang Denk
2009-04-03 23:28 ` Michael Zaidman
2009-04-24 19:45 ` Wolfgang Denk
2009-04-24 23:41 ` Ben Warren
2009-04-27 22:09 ` Wolfgang Denk
2009-04-28 5:41 ` [U-Boot] [PATCH] [PATCH v3] " Heiko Schocher
2009-04-28 7:09 ` Ben Warren
2009-04-28 6:21 ` Heiko Schocher
2009-04-28 6:36 ` [U-Boot] [PATCH v4] " Heiko Schocher
2009-04-28 17:22 ` Ben Warren
2009-05-15 19:18 ` Wolfgang Denk
2009-05-15 19:18 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902251201.45611.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox