* [U-Boot] [PATCH 1/1] Fix for running examples on OMAP3 EVM board
@ 2009-03-03 3:40 Manikandan Pillai
2009-03-03 8:35 ` Nishanth Menon
0 siblings, 1 reply; 10+ messages in thread
From: Manikandan Pillai @ 2009-03-03 3:40 UTC (permalink / raw)
To: u-boot
Example binaries to be downloaded to 0x80300000 for OMAP3 EVMs.
Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
---
examples/Makefile | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/examples/Makefile b/examples/Makefile
index dbcfa92..75e6c87 100644
--- a/examples/Makefile
+++ b/examples/Makefile
@@ -36,10 +36,14 @@ else
ifeq ($(CPU),omap3)
LOAD_ADDR = 0x80300000
else
+ifeq ($(CPU),arm_cortexa8)
+LOAD_ADDR = 0x80300000
+else
LOAD_ADDR = 0xc100000
endif
endif
endif
+endif
ifeq ($(ARCH),mips)
LOAD_ADDR = 0x80200000 -T mips.lds
--
1.5.6
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/1] Fix for running examples on OMAP3 EVM board
2009-03-03 3:40 [U-Boot] [PATCH 1/1] Fix for running examples on OMAP3 EVM board Manikandan Pillai
@ 2009-03-03 8:35 ` Nishanth Menon
2009-03-04 0:16 ` Dirk Behme
0 siblings, 1 reply; 10+ messages in thread
From: Nishanth Menon @ 2009-03-03 8:35 UTC (permalink / raw)
To: u-boot
Manikandan Pillai said the following on 03/03/2009 05:40 AM:
> Example binaries to be downloaded to 0x80300000 for OMAP3 EVMs.
>
> Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
> ---
> examples/Makefile | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/examples/Makefile b/examples/Makefile
> index dbcfa92..75e6c87 100644
> --- a/examples/Makefile
> +++ b/examples/Makefile
> @@ -36,10 +36,14 @@ else
> ifeq ($(CPU),omap3)
> LOAD_ADDR = 0x80300000
> else
> +ifeq ($(CPU),arm_cortexa8)
> +LOAD_ADDR = 0x80300000
> +else
>
I am bit confused here.. first we say $(CPU) omap3...EVM is based on
omap3 rt?
the second change is not valid -> cortex_a8 -> we might have future
platforms which have cortex. they need not use the same memory map as
OMAP does. this is not valid change. NAK from me.
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/1] Fix for running examples on OMAP3 EVM board
2009-03-03 8:35 ` Nishanth Menon
@ 2009-03-04 0:16 ` Dirk Behme
2009-03-04 4:57 ` Pillai, Manikandan
0 siblings, 1 reply; 10+ messages in thread
From: Dirk Behme @ 2009-03-04 0:16 UTC (permalink / raw)
To: u-boot
Nishanth Menon wrote:
> Manikandan Pillai said the following on 03/03/2009 05:40 AM:
>> Example binaries to be downloaded to 0x80300000 for OMAP3 EVMs.
>>
>> Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
>> ---
>> examples/Makefile | 4 ++++
>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/examples/Makefile b/examples/Makefile
>> index dbcfa92..75e6c87 100644
>> --- a/examples/Makefile
>> +++ b/examples/Makefile
>> @@ -36,10 +36,14 @@ else
>> ifeq ($(CPU),omap3)
>> LOAD_ADDR = 0x80300000
>> else
>> +ifeq ($(CPU),arm_cortexa8)
>> +LOAD_ADDR = 0x80300000
>> +else
>>
> I am bit confused here.. first we say $(CPU) omap3...EVM is based on
> omap3 rt?
> the second change is not valid -> cortex_a8 -> we might have future
> platforms which have cortex. they need not use the same memory map as
> OMAP does. this is not valid change. NAK from me.
Even if it becomes boring, I agree to Nishanth again. NACK from me, too.
Best regards
Dirk
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/1] Fix for running examples on OMAP3 EVM board
2009-03-04 0:16 ` Dirk Behme
@ 2009-03-04 4:57 ` Pillai, Manikandan
2009-03-04 6:18 ` Nishanth Menon
2009-03-04 8:32 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 2 replies; 10+ messages in thread
From: Pillai, Manikandan @ 2009-03-04 4:57 UTC (permalink / raw)
To: u-boot
Hi all,
For the EVM board,
$BOARD = evm $CPU = arm_cortexa8 and $ARCH = arm.
$VENDOR = omap3 and $SOC = omap3
I can change the check to check BOARD so that it is applicable only
To OMAP3 EVMs.
ifeq ($(BOARD),evm)
LOAD_ADDR = 0x80300000
else
Regards
Mani
> -----Original Message-----
> From: Dirk Behme [mailto:dirk.behme at googlemail.com]
> Sent: Wednesday, March 04, 2009 5:47 AM
> To: u-boot at lists.denx.de
> Cc: Nishanth Menon; Pillai, Manikandan
> Subject: Re: [U-Boot] [PATCH 1/1] Fix for running examples on OMAP3 EVM board
>
> Nishanth Menon wrote:
> > Manikandan Pillai said the following on 03/03/2009 05:40 AM:
> >> Example binaries to be downloaded to 0x80300000 for OMAP3 EVMs.
> >>
> >> Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
> >> ---
> >> examples/Makefile | 4 ++++
> >> 1 files changed, 4 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/examples/Makefile b/examples/Makefile
> >> index dbcfa92..75e6c87 100644
> >> --- a/examples/Makefile
> >> +++ b/examples/Makefile
> >> @@ -36,10 +36,14 @@ else
> >> ifeq ($(CPU),omap3)
> >> LOAD_ADDR = 0x80300000
> >> else
> >> +ifeq ($(CPU),arm_cortexa8)
> >> +LOAD_ADDR = 0x80300000
> >> +else
> >>
> > I am bit confused here.. first we say $(CPU) omap3...EVM is based on
> > omap3 rt?
> > the second change is not valid -> cortex_a8 -> we might have future
> > platforms which have cortex. they need not use the same memory map as
> > OMAP does. this is not valid change. NAK from me.
>
> Even if it becomes boring, I agree to Nishanth again. NACK from me, too.
>
> Best regards
>
> Dirk
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/1] Fix for running examples on OMAP3 EVM board
2009-03-04 4:57 ` Pillai, Manikandan
@ 2009-03-04 6:18 ` Nishanth Menon
2009-03-04 6:21 ` Pillai, Manikandan
2009-03-04 8:32 ` Jean-Christophe PLAGNIOL-VILLARD
1 sibling, 1 reply; 10+ messages in thread
From: Nishanth Menon @ 2009-03-04 6:18 UTC (permalink / raw)
To: u-boot
Pillai, Manikandan said the following on 03/04/2009 06:57 AM:
> Hi all,
>
please dont top post.
> For the EVM board,
>
> $BOARD = evm $CPU = arm_cortexa8 and $ARCH = arm.
> $VENDOR = omap3 and $SOC = omap3
>
> I can change the check to check BOARD so that it is applicable only
> To OMAP3 EVMs.
>
> ifeq ($(BOARD),evm)
> LOAD_ADDR = 0x80300000
> else
>
what is so special about evm? ;) if we have an exception from the
current boards supported, lets go ahead and do it..
mebbe the right fix would be replace $CPU, omap3 with $SOC,omap3?
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/1] Fix for running examples on OMAP3 EVM board
2009-03-04 6:18 ` Nishanth Menon
@ 2009-03-04 6:21 ` Pillai, Manikandan
0 siblings, 0 replies; 10+ messages in thread
From: Pillai, Manikandan @ 2009-03-04 6:21 UTC (permalink / raw)
To: u-boot
Hi,
Fine with me. I can change the CPU-omap3 to SOC-omap3.
> -----Original Message-----
> From: Nishanth Menon [mailto:menon.nishanth at gmail.com]
> Sent: Wednesday, March 04, 2009 11:49 AM
> To: Pillai, Manikandan
> Cc: Dirk Behme; u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH 1/1] Fix for running examples on OMAP3 EVM board
>
> Pillai, Manikandan said the following on 03/04/2009 06:57 AM:
> > Hi all,
> >
> please dont top post.
> > For the EVM board,
> >
> > $BOARD = evm $CPU = arm_cortexa8 and $ARCH = arm.
> > $VENDOR = omap3 and $SOC = omap3
> >
> > I can change the check to check BOARD so that it is applicable only
> > To OMAP3 EVMs.
> >
> > ifeq ($(BOARD),evm)
> > LOAD_ADDR = 0x80300000
> > else
> >
> what is so special about evm? ;) if we have an exception from the
> current boards supported, lets go ahead and do it..
> mebbe the right fix would be replace $CPU, omap3 with $SOC,omap3?
> Regards,
> Nishanth Menon
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/1] Fix for running examples on OMAP3 EVM board
2009-03-04 4:57 ` Pillai, Manikandan
2009-03-04 6:18 ` Nishanth Menon
@ 2009-03-04 8:32 ` Jean-Christophe PLAGNIOL-VILLARD
1 sibling, 0 replies; 10+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2009-03-04 8:32 UTC (permalink / raw)
To: u-boot
On 10:27 Wed 04 Mar , Pillai, Manikandan wrote:
> Hi all,
>
> For the EVM board,
>
> $BOARD = evm $CPU = arm_cortexa8 and $ARCH = arm.
> $VENDOR = omap3 and $SOC = omap3
>
> I can change the check to check BOARD so that it is applicable only
> To OMAP3 EVMs.
>
> ifeq ($(BOARD),evm)
> LOAD_ADDR = 0x80300000
> else
>
NACK
what is so special with evm?
and stop to add more and more ifeq in the example/Makefile
please create a EXAMPLE_LOAD_ADDR
that could be overwrite in followaing order
ARCH
CPU
SOC
BOARD
via the corresponding config.mk
Best Regards,
J.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/1] Fix for running examples on OMAP3 EVM board
@ 2009-03-05 5:55 Manikandan Pillai
2009-03-05 7:06 ` Nishanth Menon
2009-03-05 14:56 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 2 replies; 10+ messages in thread
From: Manikandan Pillai @ 2009-03-05 5:55 UTC (permalink / raw)
To: u-boot
Example binaries to be downloaded to 0x80300000 for OMAP3 EVMs.
Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
---
examples/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/examples/Makefile b/examples/Makefile
index dbcfa92..d2e811a 100644
--- a/examples/Makefile
+++ b/examples/Makefile
@@ -33,7 +33,7 @@ ifeq ($(ARCH),arm)
ifeq ($(BOARD),omap2420h4)
LOAD_ADDR = 0x80300000
else
-ifeq ($(CPU),omap3)
+ifeq ($(SOC),omap3)
LOAD_ADDR = 0x80300000
else
LOAD_ADDR = 0xc100000
--
1.5.6
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/1] Fix for running examples on OMAP3 EVM board
2009-03-05 5:55 Manikandan Pillai
@ 2009-03-05 7:06 ` Nishanth Menon
2009-03-05 14:56 ` Jean-Christophe PLAGNIOL-VILLARD
1 sibling, 0 replies; 10+ messages in thread
From: Nishanth Menon @ 2009-03-05 7:06 UTC (permalink / raw)
To: u-boot
Manikandan Pillai said the following on 03/05/2009 07:55 AM:
> Example binaries to be downloaded to 0x80300000 for OMAP3 EVMs.
>
> Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
> ---
> examples/Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/examples/Makefile b/examples/Makefile
> index dbcfa92..d2e811a 100644
> --- a/examples/Makefile
> +++ b/examples/Makefile
> @@ -33,7 +33,7 @@ ifeq ($(ARCH),arm)
> ifeq ($(BOARD),omap2420h4)
> LOAD_ADDR = 0x80300000
> else
> -ifeq ($(CPU),omap3)
> +ifeq ($(SOC),omap3)
> LOAD_ADDR = 0x80300000
> else
> LOAD_ADDR = 0xc100000
>
Acked-by: Nishanth Menon <nm@ti.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/1] Fix for running examples on OMAP3 EVM board
2009-03-05 5:55 Manikandan Pillai
2009-03-05 7:06 ` Nishanth Menon
@ 2009-03-05 14:56 ` Jean-Christophe PLAGNIOL-VILLARD
1 sibling, 0 replies; 10+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2009-03-05 14:56 UTC (permalink / raw)
To: u-boot
On 11:25 Thu 05 Mar , Manikandan Pillai wrote:
> Example binaries to be downloaded to 0x80300000 for OMAP3 EVMs.
>
> Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
> ---
> examples/Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/examples/Makefile b/examples/Makefile
> index dbcfa92..d2e811a 100644
> --- a/examples/Makefile
> +++ b/examples/Makefile
> @@ -33,7 +33,7 @@ ifeq ($(ARCH),arm)
> ifeq ($(BOARD),omap2420h4)
> LOAD_ADDR = 0x80300000
> else
> -ifeq ($(CPU),omap3)
> +ifeq ($(SOC),omap3)
> LOAD_ADDR = 0x80300000
> else
> LOAD_ADDR = 0xc100000
sorry I'll prefer this patch
[PATCH] example: introduce EXAMPLE_LOAD_ADDR
more flexible and more clean
Best Regards,
J.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2009-03-05 14:56 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-03 3:40 [U-Boot] [PATCH 1/1] Fix for running examples on OMAP3 EVM board Manikandan Pillai
2009-03-03 8:35 ` Nishanth Menon
2009-03-04 0:16 ` Dirk Behme
2009-03-04 4:57 ` Pillai, Manikandan
2009-03-04 6:18 ` Nishanth Menon
2009-03-04 6:21 ` Pillai, Manikandan
2009-03-04 8:32 ` Jean-Christophe PLAGNIOL-VILLARD
-- strict thread matches above, loose matches on Subject: below --
2009-03-05 5:55 Manikandan Pillai
2009-03-05 7:06 ` Nishanth Menon
2009-03-05 14:56 ` Jean-Christophe PLAGNIOL-VILLARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox