From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Seperate mtdpart command from jffs2
Date: Mon, 9 Mar 2009 11:20:44 +0100 [thread overview]
Message-ID: <20090309102044.GI24237@game.jcrosoft.org> (raw)
In-Reply-To: <200903091052.28759.sr@denx.de>
On 10:52 Mon 09 Mar , Stefan Roese wrote:
> Hi Jean-Christophe,
>
> On Monday 09 March 2009, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 09:14 Mon 09 Mar , Stefan Roese wrote:
> > > On Monday 09 March 2009, Kyungmin Park wrote:
> > > > >> +++ b/common/Makefile
> > > > >> @@ -98,6 +98,7 @@ COBJS-$(CONFIG_CMD_IMMAP) += cmd_immap.o
> > > > >> ?COBJS-$(CONFIG_CMD_IRQ) += cmd_irq.o
> > > > >> ?COBJS-$(CONFIG_CMD_ITEST) += cmd_itest.o
> > > > >> ?COBJS-$(CONFIG_CMD_JFFS2) += cmd_jffs2.o
> > > > >> +COBJS-$(CONFIG_JFFS2_CMDLINE) += cmd_mtdparts.o
> > > > >
> > > > > Shouldn't we change this define (CONFIG_JFFS2_CMDLINE) to something
> > > > > else now, since it's not really JFFS2 specific anymore? I suggest to
> > > > > change it to CONFIG_CMD_MTDPARTS. This seems more logical to me.
> > > > >
> > > > > What do you think?
> > > >
> > > > It's already done by Jean-Christophe PLAGNIOL-VILLARD. Isn't it?
> > >
> > > Is it? I have not seen such a patch. Do you have a link? (I added
> > > Jean-Christophe to CC).
> >
> > http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=9163868e5575d841089a
> >84d97f287b2ca15486a1
>
> Hmm. Now I'm a little confused. It seems that you added this patch with some
> changes to the "for-next" branch of your arm git repository. Did you post the
> changed version of this patch on the list? I couldn't find it.
>
> Don't get me wrong. I appreciate that you did the required change to the
> patch. But please post the path on the list after you changed it.
yes but was too big and automaticly-reject
> And also
> please incorporate the change to the patch description as I suggested.
which?
> Additionally I think that this patch doesn't really belong into your arm
> repository.
I've put here due to the ML limit that's all
Best Regards,
J.
next prev parent reply other threads:[~2009-03-09 10:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 5:03 [U-Boot] [PATCH] Seperate mtdpart command from jffs2 Kyungmin Park
2009-03-03 8:41 ` Stefan Roese
2009-03-06 13:13 ` Stefan Roese
2009-03-08 22:12 ` Wolfgang Denk
2009-03-09 3:08 ` Kyungmin Park
2009-03-09 8:14 ` Stefan Roese
2009-03-09 9:22 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-09 9:52 ` Stefan Roese
2009-03-09 10:20 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-03-09 10:43 ` Stefan Roese
2009-03-09 11:24 ` Wolfgang Denk
2009-03-09 11:23 ` Wolfgang Denk
2009-03-09 20:13 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-09 21:53 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090309102044.GI24237@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox