From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Date: Mon, 9 Mar 2009 13:09:54 +0100
Subject: [U-Boot] [PATCH 7/9] at91rm9200: fix DCC support
In-Reply-To: <20090309113743.5FC75832E8B8@gemini.denx.de>
References: <1236089265-24598-3-git-send-email-plagnioj@jcrosoft.com>
	<1236089265-24598-4-git-send-email-plagnioj@jcrosoft.com>
	<1236089265-24598-5-git-send-email-plagnioj@jcrosoft.com>
	<1236089265-24598-6-git-send-email-plagnioj@jcrosoft.com>
	<1236089265-24598-7-git-send-email-plagnioj@jcrosoft.com>
	<20090308233132.D8875832E8B8@gemini.denx.de>
	<20090309083649.GE24237@game.jcrosoft.org>
	<20090309111949.8FEBD832E8B8@gemini.denx.de>
	<20090309111835.GJ24237@game.jcrosoft.org>
	<20090309113743.5FC75832E8B8@gemini.denx.de>
Message-ID: <20090309120954.GK24237@game.jcrosoft.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 12:37 Mon 09 Mar     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <20090309111835.GJ24237@game.jcrosoft.org> you wrote:
> >
> > > > > Why the #ifdef? Shutting down the console seems a good thing to me.
> > > > when using DCC we will not activate the at91 uart at all so we do not have to
> > > > shut it down
> > > 
> > > The #ifdef above does not seem to depend on DCC at all?
> 
> You did not answer this question.
> 
> > > And what does it hurt if we always shut down the console? To me that
> > > looks clearer than an additional #ifdef.
the UART code is not active or compile so you can't do it.
> 
> So what if we use "DCC multi support"? (whatever this is - or do you
> mean CONFIG_SERIAL_MULTI instead?)
yes the DCC can be optionnaly compile with the CONFIG_SERIAL_MULTI support
but not necessarely
> 
> > We must shutdown the console only if we use it which is not the case when we use
> > the DCC as principal serial
> 
> You did not answer my question. Even if there is no need to shut it
> down if it was not used - what does it hurt if we do this always?
we can't because the code needed to do it is not even compiled

Best Regards,
J.