[U-Boot] [PATCH 7/9] at91rm9200: fix DCC support

Wolfgang Denk
2009-03-08T23:31:32Z

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1236089265-24598-7-git-send-email-plagnioj@jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> cpu/arm920t/at91rm9200/interrupts.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)

Please explain which problem you are trying to fix.

> diff --git a/cpu/arm920t/at91rm9200/interrupts.c b/cpu/arm920t/at91rm9200/interrupts.c
> index 5f0703c..3e35f68 100644
> --- a/cpu/arm920t/at91rm9200/interrupts.c
> +++ b/cpu/arm920t/at91rm9200/interrupts.c
> @@ -179,8 +179,10 @@ void reset_cpu (ulong ignored)
> AT91PS_PIO pio = AT91C_BASE_PIOA;
> #endif
>
> +#if defined(CONFIG_DBGU) || defined(CONFIG_USART0) || defined(CONFIG_USART1)
> /*shutdown the console to avoid strange chars during reset */
> us->US_CR = (AT91C_US_RSTRX | AT91C_US_RSTTX);
> +#endif

Why the #ifdef? Shutting down the console seems a good thing to me.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In accord with UNIX philosophy, Perl gives you enough rope to hang
yourself. - L. Wall & R. L. Schwartz, _Programming Perl_