[U-Boot] [PATCH 7/9] at91rm9200: fix DCC support

Wolfgang Denk
2009-03-09T11:37:43Z

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090309111835.GJ24237@game.jcrosoft.org> you wrote:
>
> > > > Why the #ifdef? Shutting down the console seems a good thing to me.
> > > when using DCC we will not activate the at91 uart at all so we do not have to
> > > shut it down
> >
> > The #ifdef above does not seem to depend on DCC at all?

You did not answer this question.

> > And what does it hurt if we always shut down the console? To me that
> > looks clearer than an additional #ifdef.

You did not answer this question.

> > Finally, what if somebody wants to use DCC and an UART simultaneously?
> > I guess that should be possible, too.
> It's not possible if you do not use the DCC multi support because the DCC will
> replace the uart.

So what if we use "DCC multi support"? (whatever this is - or do you
mean CONFIG_SERIAL_MULTI instead?)

> We must shutdown the console only if we use it which is not the case when we use
> the DCC as principal serial

You did not answer my question. Even if there is no need to shut it
down if it was not used - what does it hurt if we do this always?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Mirrors should reflect a little before throwing back images.
- Jean Cocteau