[U-Boot] [PATCH 8/9] at91sam9263ek add dcc support with at91sam9263ek_dcc_config

Jean-Christophe PLAGNIOL-VILLARD
2009-03-09T08:35:08Z

On 00:33 Mon 09 Mar , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
>
> In message <1236089265-24598-8-git-send-email-plagnioj@jcrosoft.com> you wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > Makefile | 11 +++++++++++
> > include/configs/at91sam9263ek.h | 2 ++
> > 2 files changed, 13 insertions(+), 0 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 784af52..50ce78e 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -2687,6 +2687,8 @@ at91sam9261ek_config : unconfig
> > at91sam9263ek_nandflash_config \
> > at91sam9263ek_dataflash_config \
> > at91sam9263ek_dataflash_cs0_config \
> > +at91sam9263ek_dcc_multi_config \
> > +at91sam9263ek_dcc_config \
> > at91sam9263ek_wdt_config \
> > at91sam9263ek_config : unconfig
>
> NAK. NAK. NAK.
>
> As explained before, this makes no sense. Why could we not have DCC
> support with any of the other options?
we can but I wish not to add 1000 of config, just one or two to build it and
test it on each release
>
> Also, you are adding more and more cruft to the Makefile. This is not
> acceptable.
>
> Finally, there should be some commit message that explains what you
> are doing. For example, you should at least give a minimal
> explanation what DCC is and why we might want to add this....
I've add DCC is used a serial over ICE so it will replace the serial port of
the board

Best Regards,
J.