public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/7] eSPI: add eSPI controller support
Date: Mon, 16 Mar 2009 03:28:08 -0400	[thread overview]
Message-ID: <200903160328.09696.vapier@gentoo.org> (raw)
In-Reply-To: <20090316061527.GB30225@game.jcrosoft.org>

On Monday 16 March 2009 02:15:27 Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 10:52 Mon 16 Mar     , Mingkai Hu wrote:
> > Add eSPI controller support under the SPI framework.
> >
> > Signed-off-by: Mingkai Hu <Mingkai.hu@freescale.com>
> > ---
> >  drivers/mtd/spi/spi_flash.c |   94 +++++++++++++++++-
> >  drivers/spi/Makefile        |    1 +
> >  drivers/spi/fsl_espi.c      |  232
> > +++++++++++++++++++++++++++++++++++++++++++ include/spi.h               |
> >   30 ++++++
> >  4 files changed, 354 insertions(+), 3 deletions(-)
> >  create mode 100644 drivers/spi/fsl_espi.c
>
> please use the spi framework, their is no need to touch the spi_flash
> support ti add and use the fsl_espi

indeed ... i was so happy to see the spansion driver i glossed over this ... 
those spi_flash.c changes are almost assuredly wrong and indicate you arent 
fitting into the framework correctly.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090316/766d68ff/attachment.pgp 

  reply	other threads:[~2009-03-16  7:28 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-16  2:52 [U-Boot] [PATCH 1/7] eSPI: add the eSPI register support Mingkai Hu
2009-03-16  2:52 ` [U-Boot] [PATCH 2/7] mtd: SPI Flash: Support the Spansion Flash Mingkai Hu
2009-03-16  2:52   ` [U-Boot] [PATCH 3/7] eSPI: add eSPI controller support Mingkai Hu
2009-03-16  2:52     ` [U-Boot] [PATCH 4/7] eSPI: make the chip selsec enable Mingkai Hu
2009-03-16  2:52       ` [U-Boot] [PATCH 5/7] Make a special uboot used for booting from SDcard or SPI flash Mingkai Hu
2009-03-16  2:52         ` [U-Boot] [PATCH 6/7] Add support for save the env to SDcard Mingkai Hu
2009-03-16  2:52           ` [U-Boot] [PATCH 7/7] Save the env variables to SDcard and SPI flash for MPC8536DS Mingkai Hu
2009-03-16  8:56             ` Wolfgang Denk
2009-03-16  7:25           ` [U-Boot] [PATCH 6/7] Add support for save the env to SDcard Mike Frysinger
2009-03-16  8:55         ` [U-Boot] [PATCH 5/7] Make a special uboot used for booting from SDcard or SPI flash Wolfgang Denk
2009-03-17 12:16           ` Hu Mingkai-B21284
2009-03-17 12:30             ` Wolfgang Denk
2009-03-18 17:15               ` Scott Wood
2009-03-18 19:29                 ` Wolfgang Denk
2009-03-18 19:57                   ` Scott Wood
2009-03-18 20:13                     ` Wolfgang Denk
2009-03-18 20:15                       ` Scott Wood
2009-03-18 21:11                         ` Wolfgang Denk
2009-08-27  2:43               ` Hu Mingkai-B21284
2009-03-16  6:15     ` [U-Boot] [PATCH 3/7] eSPI: add eSPI controller support Jean-Christophe PLAGNIOL-VILLARD
2009-03-16  7:28       ` Mike Frysinger [this message]
2009-03-16  8:56         ` Hu Mingkai-B21284
2009-03-16 10:05           ` Mike Frysinger
2009-08-27  3:01             ` Hu Mingkai-B21284
2009-08-27  5:53               ` Mike Frysinger
2009-08-27  6:27                 ` Hu Mingkai-B21284
2009-08-27  6:43                   ` Mike Frysinger
2009-08-27  6:59                     ` Hu Mingkai-B21284
2009-08-27  7:22                       ` Mike Frysinger
2009-08-27  7:47                         ` Hu Mingkai-B21284
2009-03-16 11:58     ` Scott McNutt
2009-03-16  4:38   ` [U-Boot] [PATCH 2/7] mtd: SPI Flash: Support the Spansion Flash Mike Frysinger
2009-03-16  6:23     ` Hu Mingkai-B21284
2009-03-29 19:34       ` Mike Frysinger
2009-03-31  1:12   ` Mike Frysinger
2009-03-31  5:51     ` Hu Mingkai-B21284

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903160328.09696.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox