From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Fri, 20 Mar 2009 11:51:23 +0100
Subject: [U-Boot] [PATCH v2] UBIFS: Missing offset relocation for
	compressor 'none'
In-Reply-To: <m2fxh879ra.fsf@ohwell.denx.de>
References: <49C20B21.1080005@gmx.de> <200903200831.32171.sr@denx.de>
	<m2fxh879ra.fsf@ohwell.denx.de>
Message-ID: <200903201151.23448.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Detlev,

On Friday 20 March 2009, Detlev Zundel wrote:
> > Please note that I explicitly didn't fold this patch into my latest UBIFS
> > patch series. We should apply it after UBIFS is available in mainline so
> > that Michael will be listed as author for this fix.
>
> I was not so sure about this, so I was waiting for your opinion, but are
> you sure that it is ok to remove the assignment?  Doesn't other code
> depend on that?
>
> @@ -147,7 +147,10 @@ int __init ubifs_compressors_init(void)
>         if (err)
>                 return err;
>
> -       ubifs_compressors[UBIFS_COMPR_NONE] = &none_compr;
> +       err = compr_init(&none_compr);
> +       if (err)
> +               return err;
> +
>         return 0;
>  }

Yes, I'm pretty sure this patch is correct. The removed assignment is done in 
compr_init() as well:

/**
 * compr_init - initialize a compressor.
 * @compr: compressor description object
 *
 * This function initializes the requested compressor and returns zero in case
 * of success or a negative error code in case of failure.
 */
static int __init compr_init(struct ubifs_compressor *compr)
{
	ubifs_compressors[compr->compr_type] = compr;
	ubifs_compressors[compr->compr_type]->name += gd->reloc_off;
	ubifs_compressors[compr->compr_type]->capi_name += gd->reloc_off;
	ubifs_compressors[compr->compr_type]->decompress += gd->reloc_off;
	return 0;
}

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================