public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jon <jonsmirl@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] mpc5200: do not use printf in i2c_init()
Date: Sat, 21 Mar 2009 09:38:44 -0400	[thread overview]
Message-ID: <20090321133844.11905.61201.stgit@localhost> (raw)
In-Reply-To: <20090321133727.11905.38048.stgit@localhost>

From: Sascha Hauer <s.hauer@pengutronix.de>

On boards which have the environment in eeprom, i2c_init()
is called before the console and ram is initialized. Do
not printf here.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 cpu/mpc5xxx/i2c.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/cpu/mpc5xxx/i2c.c b/cpu/mpc5xxx/i2c.c
index 7d76274..843af9c 100644
--- a/cpu/mpc5xxx/i2c.c
+++ b/cpu/mpc5xxx/i2c.c
@@ -269,7 +269,6 @@ static int mpc_get_fdr(int speed)
 		if (gd->flags & GD_FLG_RELOC) {
 			fdr = divider;
 		} else {
-			printf("%ld kHz, ", best_speed / 1000);
 			return divider;
 		}
 	}
@@ -310,29 +309,24 @@ int i2c_read(uchar chip, uint addr, int alen, uchar *buf, int len)
 	xaddr[3] =  addr	& 0xFF;
 
 	if (wait_for_bb()) {
-		printf("i2c_read: bus is busy\n");
 		goto Done;
 	}
 
 	mpc_reg_out(&regs->mcr, I2C_STA, I2C_STA);
 	if (do_address(chip, 0)) {
-		printf("i2c_read: failed to address chip\n");
 		goto Done;
 	}
 
 	if (send_bytes(chip, &xaddr[4-alen], alen)) {
-		printf("i2c_read: send_bytes failed\n");
 		goto Done;
 	}
 
 	mpc_reg_out(&regs->mcr, I2C_RSTA, I2C_RSTA);
 	if (do_address(chip, 1)) {
-		printf("i2c_read: failed to address chip\n");
 		goto Done;
 	}
 
 	if (receive_bytes(chip, (char *)buf, len)) {
-		printf("i2c_read: receive_bytes failed\n");
 		goto Done;
 	}
 
@@ -354,23 +348,19 @@ int i2c_write(uchar chip, uint addr, int alen, uchar *buf, int len)
 	xaddr[3] =  addr	& 0xFF;
 
 	if (wait_for_bb()) {
-		printf("i2c_write: bus is busy\n");
 		goto Done;
 	}
 
 	mpc_reg_out(&regs->mcr, I2C_STA, I2C_STA);
 	if (do_address(chip, 0)) {
-		printf("i2c_write: failed to address chip\n");
 		goto Done;
 	}
 
 	if (send_bytes(chip, &xaddr[4-alen], alen)) {
-		printf("i2c_write: send_bytes failed\n");
 		goto Done;
 	}
 
 	if (send_bytes(chip, (char *)buf, len)) {
-		printf("i2c_write: send_bytes failed\n");
 		goto Done;
 	}
 

  reply	other threads:[~2009-03-21 13:38 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-21 13:38 [U-Boot] [PATCH 0/3] Three mpc5200 patches from Pengutronix.de Jon
2009-03-21 13:38 ` Jon [this message]
2009-03-21 19:47   ` [U-Boot] [PATCH 1/3] mpc5200: do not use printf in i2c_init() Wolfgang Denk
2009-03-21 20:39     ` Jon Smirl
2009-03-21 20:54       ` Wolfgang Denk
2009-03-21 20:56       ` Wolfgang Denk
2009-03-22 14:01         ` Jon Smirl
2009-03-22 14:21           ` Wolfgang Denk
2009-03-22 14:23             ` Jon Smirl
2009-03-22 15:23               ` Wolfgang Denk
2009-03-23  2:55                 ` Jon Smirl
2009-03-24  8:38                   ` Heiko Schocher
2009-03-25 21:51                   ` Wolfgang Denk
2009-03-25 22:31                     ` Jon Smirl
2009-03-21 13:38 ` [U-Boot] [PATCH 2/3] mpc52xx phy: initialize only when needed Jon
2009-03-25 19:12   ` Jon Smirl
2009-03-25 21:53     ` Wolfgang Denk
2009-03-31  1:04       ` Jon Smirl
2009-03-31  6:13         ` Ben Warren
2009-04-04 20:37   ` Wolfgang Denk
2009-03-21 13:38 ` [U-Boot] [PATCH 3/3] mpc5200: make i2c faster Jon
2009-03-21 19:48   ` Wolfgang Denk
2009-03-22 14:20     ` Jon Smirl
2009-03-22 15:21       ` Wolfgang Denk
2009-03-23  2:59         ` Jon Smirl
2009-03-23  8:24           ` Wolfgang Denk
2009-03-22 23:16   ` Sascha Hauer
2009-03-23  3:00     ` Grant Likely
2009-03-23  6:24       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090321133844.11905.61201.stgit@localhost \
    --to=jonsmirl@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox