public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jon <jonsmirl@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] mpc52xx phy: initialize only when needed
Date: Sat, 21 Mar 2009 09:38:46 -0400	[thread overview]
Message-ID: <20090321133846.11905.81764.stgit@localhost> (raw)
In-Reply-To: <20090321133727.11905.38048.stgit@localhost>

From: Sascha Hauer <s.hauer@pengutronix.de>

Do not initialize phy on startup, instead initialize it
when we actually need it.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/net/mpc5xxx_fec.c |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mpc5xxx_fec.c b/drivers/net/mpc5xxx_fec.c
index 0f1d1af..1876b76 100644
--- a/drivers/net/mpc5xxx_fec.c
+++ b/drivers/net/mpc5xxx_fec.c
@@ -42,6 +42,8 @@ typedef struct {
 int fec5xxx_miiphy_read(char *devname, uint8 phyAddr, uint8 regAddr, uint16 * retVal);
 int fec5xxx_miiphy_write(char *devname, uint8 phyAddr, uint8 regAddr, uint16 data);
 
+static int mpc5xxx_fec_init_phy(struct eth_device *dev, bd_t * bis);
+
 /********************************************************************/
 #if (DEBUG & 0x2)
 static void mpc5xxx_fec_phydump (char *devname)
@@ -249,6 +251,8 @@ static int mpc5xxx_fec_init(struct eth_device *dev, bd_t * bis)
 	printf ("mpc5xxx_fec_init... Begin\n");
 #endif
 
+	mpc5xxx_fec_init_phy(dev, bis);
+
 	/*
 	 * Initialize RxBD/TxBD rings
 	 */
@@ -387,6 +391,11 @@ static int mpc5xxx_fec_init_phy(struct eth_device *dev, bd_t * bis)
 {
 	mpc5xxx_fec_priv *fec = (mpc5xxx_fec_priv *)dev->priv;
 	const uint8 phyAddr = CONFIG_PHY_ADDR;	/* Only one PHY */
+	static int initialized = 0;
+
+	if(initialized)
+		return 0;
+	initialized = 1;
 
 #if (DEBUG & 0x1)
 	printf ("mpc5xxx_fec_init_phy... Begin\n");
@@ -937,8 +946,6 @@ int mpc5xxx_fec_initialize(bd_t * bis)
 		mpc5xxx_fec_set_hwaddr(fec, env_enetaddr);
 	}
 
-	mpc5xxx_fec_init_phy(dev, bis);
-
 	return 1;
 }
 

  parent reply	other threads:[~2009-03-21 13:38 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-21 13:38 [U-Boot] [PATCH 0/3] Three mpc5200 patches from Pengutronix.de Jon
2009-03-21 13:38 ` [U-Boot] [PATCH 1/3] mpc5200: do not use printf in i2c_init() Jon
2009-03-21 19:47   ` Wolfgang Denk
2009-03-21 20:39     ` Jon Smirl
2009-03-21 20:54       ` Wolfgang Denk
2009-03-21 20:56       ` Wolfgang Denk
2009-03-22 14:01         ` Jon Smirl
2009-03-22 14:21           ` Wolfgang Denk
2009-03-22 14:23             ` Jon Smirl
2009-03-22 15:23               ` Wolfgang Denk
2009-03-23  2:55                 ` Jon Smirl
2009-03-24  8:38                   ` Heiko Schocher
2009-03-25 21:51                   ` Wolfgang Denk
2009-03-25 22:31                     ` Jon Smirl
2009-03-21 13:38 ` Jon [this message]
2009-03-25 19:12   ` [U-Boot] [PATCH 2/3] mpc52xx phy: initialize only when needed Jon Smirl
2009-03-25 21:53     ` Wolfgang Denk
2009-03-31  1:04       ` Jon Smirl
2009-03-31  6:13         ` Ben Warren
2009-04-04 20:37   ` Wolfgang Denk
2009-03-21 13:38 ` [U-Boot] [PATCH 3/3] mpc5200: make i2c faster Jon
2009-03-21 19:48   ` Wolfgang Denk
2009-03-22 14:20     ` Jon Smirl
2009-03-22 15:21       ` Wolfgang Denk
2009-03-23  2:59         ` Jon Smirl
2009-03-23  8:24           ` Wolfgang Denk
2009-03-22 23:16   ` Sascha Hauer
2009-03-23  3:00     ` Grant Likely
2009-03-23  6:24       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090321133846.11905.81764.stgit@localhost \
    --to=jonsmirl@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox