public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jon <jonsmirl@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Make flash protection work, when the environment is in EEPROM
Date: Sat, 21 Mar 2009 09:59:34 -0400	[thread overview]
Message-ID: <20090321135934.12464.65400.stgit@localhost> (raw)

From: Eric Schumann <E.Schumann@phytec.de>

On the pcm030 the environment is located in the onboard EEPROM. But we want
to handle flash sector protection in a safe manner. So we must read the
unlock environment variable from EEPROM instead from flash.

This patch is required as long the evironment is saved into the EEPROM.

Signed-off-by: Eric Schumann <E.Schumann@phytec.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 0 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
index 391d169..1436131 100644
--- a/drivers/mtd/cfi_flash.c
+++ b/drivers/mtd/cfi_flash.c
@@ -2009,7 +2009,9 @@ unsigned long flash_init (void)
 #endif
 
 #ifdef CONFIG_SYS_FLASH_PROTECTION
-	char *s = getenv("unlock");
+	/* read environment from EEPROM */
+	char s[4];
+	getenv_r ("unlock", s, sizeof(s));
 #endif
 
 #define BANK_BASE(i)	(((phys_addr_t [CFI_MAX_FLASH_BANKS])CONFIG_SYS_FLASH_BANKS_LIST)[i])

             reply	other threads:[~2009-03-21 13:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-21 13:59 Jon [this message]
2009-03-21 19:52 ` [U-Boot] [PATCH] Make flash protection work, when the environment is in EEPROM Wolfgang Denk
2009-03-21 20:08   ` Jon Smirl
2009-03-21 20:24     ` Wolfgang Denk
2009-03-21 20:25       ` Jon Smirl
2009-03-22 22:59       ` Sascha Hauer
2009-03-23  3:01         ` Jon Smirl
2009-03-23  7:15           ` Sascha Hauer
2009-03-23  8:15           ` Wolfgang Denk
2009-03-23  8:17 ` Wolfgang Denk
2009-03-23  8:54   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090321135934.12464.65400.stgit@localhost \
    --to=jonsmirl@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox