From: Ladislav Michl <ladis@linux-mips.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] Separate mtdparts command from jffs2
Date: Mon, 23 Mar 2009 12:06:07 +0100 [thread overview]
Message-ID: <20090323110607.GB6049@localhost.localdomain> (raw)
In-Reply-To: <1237465836-26622-1-git-send-email-sr@denx.de>
On Thu, Mar 19, 2009 at 01:30:36PM +0100, Stefan Roese wrote:
> Currently the mtdparts commands are included in the jffs2 command support.
> This doesn't make sense anymore since other commands (e.g. UBI) use this
> infrastructure as well now. This patch separates the mtdparts commands from
> the jffs2 commands making it possible to only select mtdparts when no JFFS2
> support is needed.
... and to make it useful for NAND chips as well, we should also remove now
unrelated CONFIG_JFFS2_NAND. Note that struct part_info etc is in
jffs2/load_kernel.h which is a bit misleading filename for that purpose,
but that can be fixed later (tm).
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
diff --git a/common/cmd_mtdparts.c b/common/cmd_mtdparts.c
index c8bf2c6..3d437c0 100644
--- a/common/cmd_mtdparts.c
+++ b/common/cmd_mtdparts.c
@@ -84,13 +84,10 @@
*
*/
-/*
- * JFFS2/CRAMFS support
- */
#include <common.h>
#include <command.h>
#include <malloc.h>
-#include <jffs2/jffs2.h>
+#include <jffs2/load_kernel.h>
#include <linux/list.h>
#include <linux/ctype.h>
#include <cramfs/cramfs_fs.h>
@@ -375,7 +372,7 @@ static int part_validate_nor(struct mtdids *id, struct part_info *part)
*/
static int part_validate_nand(struct mtdids *id, struct part_info *part)
{
-#if defined(CONFIG_JFFS2_NAND) && defined(CONFIG_CMD_NAND)
+#if defined(CONFIG_CMD_NAND)
/* info for NAND chips */
nand_info_t *nand;
@@ -780,7 +777,7 @@ int mtd_device_validate(u8 type, u8 num, u32 *size)
printf("support for FLASH devices not present\n");
#endif
} else if (type == MTD_DEV_TYPE_NAND) {
-#if defined(CONFIG_JFFS2_NAND) && defined(CONFIG_CMD_NAND)
+#if defined(CONFIG_CMD_NAND)
if (num < CONFIG_SYS_MAX_NAND_DEVICE) {
#ifndef CONFIG_NAND_LEGACY
*size = nand_info[num].size;
next prev parent reply other threads:[~2009-03-23 11:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 12:30 [U-Boot] [PATCH v4] Separate mtdparts command from jffs2 Stefan Roese
2009-03-20 21:04 ` Wolfgang Denk
2009-03-23 11:06 ` Ladislav Michl [this message]
2009-04-04 20:42 ` Wolfgang Denk
2009-04-21 0:26 ` Ladislav Michl
2009-04-21 4:03 ` Stefan Roese
2009-04-27 23:06 ` Wolfgang Denk
2009-05-15 15:32 ` Wolfgang Denk
2009-05-16 4:08 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323110607.GB6049@localhost.localdomain \
--to=ladis@linux-mips.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox