public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Canyonlands SATA harddisk driver
Date: Tue, 24 Mar 2009 17:22:55 +0100	[thread overview]
Message-ID: <200903241722.55723.sr@denx.de> (raw)
In-Reply-To: <49C86E1D.4050601@fsi.co.jp>

On Tuesday 24 March 2009, Kazuaki Ichinohe wrote:
> This patch adds a SATA harddisk driver for the canyonlands.

Thanks.

But your patch is linewrapped and therefor hard to read and can't be applied. 
And the commit message could be a little more descriptive. And please don't 
forget to add you Signed-off-by line next time.

As a general comment I suggest that you take a look at:

http://www.denx.de/wiki/view/U-Boot/Patches

to see how patches should be posted to the list. Best would be to use the git 
tools (git format-patch and git send-email) for patch submission.

I'll make a review in more depth when you send a patch that's not linewrapped.

Thanks again.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2009-03-24 16:22 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-17 13:08 [U-Boot] About PCI of U-BOOT of CANYONLANDS Kazuaki Ichinohe
2009-03-17 13:13 ` Stefan Roese
2009-03-18  1:28   ` Kazuaki Ichinohe
2009-03-18  9:07     ` Stefan Roese
2009-03-18  9:13       ` Felix Radensky
2009-03-18  9:23         ` Stefan Roese
2009-03-18  9:34           ` Felix Radensky
2009-03-18  9:39             ` Stefan Roese
2009-03-18 12:03       ` Anatolij Gustschin
2009-03-18 12:07         ` Kazuaki Ichinohe
2009-03-18 12:29           ` Kazuaki Ichinohe
2009-03-18 13:00             ` Kazuaki Ichinohe
     [not found]             ` <49C0EFB2.9020800@fsi.co.jp>
2009-03-18 14:48               ` Anatolij Gustschin
2009-03-19  4:43                 ` Kazuaki Ichinohe
2009-03-19  9:16                   ` Anatolij Gustschin
2009-03-19 11:28                     ` Kazuaki Ichinohe
2009-03-19 11:44                       ` Anatolij Gustschin
2009-03-19 12:09                         ` Kazuaki Ichinohe
2009-03-19 12:27                           ` Anatolij Gustschin
2009-03-19 12:52                             ` Kazuaki Ichinohe
2009-03-19 13:17                               ` Anatolij Gustschin
2009-03-20 10:50                                 ` Kazuaki Ichinohe
2009-03-24  5:22 ` [U-Boot] [PATCH] Canyonlands SATA harddisk driver Kazuaki Ichinohe
2009-03-24 16:22   ` Stefan Roese [this message]
2009-03-25 11:32     ` Kazuaki Ichinohe
2009-03-25 16:04       ` Stefan Roese
2009-03-26 10:56         ` Kazuaki Ichinohe
2009-03-27 16:11           ` Stefan Roese
2009-03-27 16:31           ` Wolfgang Denk
2009-03-30  8:27             ` Kazuaki Ichinohe
2009-04-17  7:31               ` Kazuaki Ichinohe
2009-04-27  1:53                 ` Kazuaki Ichinohe
2009-04-27  7:42                   ` Stefan Roese
2009-04-29  6:58                   ` Stefan Roese
2009-05-07  6:23                     ` Kazuaki Ichinohe
2009-05-07  7:38                       ` Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2009-05-08  6:27 Kazuaki Ichinohe
2009-05-11  2:13 ` Kazuaki Ichinohe
2009-05-11 13:01 ` Stefan Roese
2009-05-12  9:29   ` Kazuaki Ichinohe
2009-05-12  9:43     ` Kazuaki Ichinohe
2009-05-12  9:56 Kazuaki Ichinohe
2009-05-12 18:42 ` Wolfgang Denk
2009-05-13  8:56 Kazuaki Ichinohe
2009-05-14  9:45 ` Stefan Roese
2009-05-14  8:28 Kazuaki Ichinohe
2009-05-14  8:57 ` Stefan Roese
2009-05-15  9:32 Kazuaki Ichinohe
2009-05-20 12:47 ` Stefan Roese
2009-05-20 21:08   ` Shinya Kuribayashi
2009-05-28 19:22 ` Wolfgang Denk
2009-05-29  7:36   ` Kazuaki Ichinohe
2009-05-29  9:07     ` Shinya Kuribayashi
2009-06-02  0:28       ` Kazuaki Ichinohe
2009-06-02  0:44         ` Shinya Kuribayashi
2009-06-04  5:00           ` Kazuaki Ichinohe
2009-06-04  6:30             ` Shinya Kuribayashi
2009-06-04  6:57               ` Stefan Roese
2009-06-04  8:40         ` Wolfgang Denk
2009-06-02  0:41       ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-12  9:10 Kazuaki Ichinohe
2009-07-19  9:24 ` Wolfgang Denk
2009-06-12  9:50 Kazuaki Ichinohe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903241722.55723.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox