From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Wed, 25 Mar 2009 12:23:19 -0500 Subject: [U-Boot] [PATCH v2 4/4] Flex-OneNAND boundary setting command In-Reply-To: <30550E23C11643FF9064DFEDC982029E@sisodomain.com> References: <49412369.6010707@samsung.com> <200903081217.36696.h.rohit@samsung.com> <20090309213855.GC24986@ld0162-tx32.am.freescale.net> <30550E23C11643FF9064DFEDC982029E@sisodomain.com> Message-ID: <20090325172319.GA23631@loki.buserror.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Mar 25, 2009 at 08:44:37PM +0530, Amul Kumar Saha wrote: > >> + die = (int) simple_strtoul(argv[2], NULL, 0); > >> + bdry = (int) simple_strtoul(argv[3], NULL, 0); > > > > Casts should not be necessary. > > > > I believe that typecasting a UL to an int, is OK. > Do let me know. The compiler will implicitly cast unsigned long to int. The explicit cast is unnecessary clutter which makes it harder to find casts that aren't OK. -Scott