[U-Boot] [PATCH 10/13] at91: move usb driver to drivers/usb

Stefan Roese
2009-04-01T06:55:55Z

On Tuesday 31 March 2009, Wolfgang Denk wrote:
> In message <20090331192117.GF24923@game.jcrosoft.org> you wrote:
> > > > ?drivers/usb/Makefile ? ? ? ? ? ? ? ? ? ? ? ?> ? ? ? | ? ?1 +
> > > > ?.../at91/usb.c => drivers/usb/atmel_usb.c ? ? ? ? ?| ?> ?0
> > > > ?rename cpu/arm926ejs/at91/usb.c => drivers/usb/atmel_usb.c (100%)
> > >
> > > Same here, this is architecture specific code, why move it to generic
> > > cod> e?
> >
> > it's the at91 usb drivers and we need to have it in the driver/usb
>
> Why do we need to have it in the driver/usb ?
>
> Please explain in detail.

From what I remember we all agreed to move the device drivers (e.g. ethernet,
NAND, USB, serial etc) from the architecture/board (cpu/... board/...) to the
drivers directories at some time.

Speaking for PPC4xx, the 4xx ethernet driver has recently been moved from
cpu/ppc4xx to drivers/net. And I'm planning to move the 4xx NAND driver (and
others) soon too.

So if this atmel_usb.c driver isn't just platform USB init code, but a real
USB driver, then I'm voting to move it to drivers/usb as well.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================